View | Details | Raw Unified | Return to bug 18420
Collapse All | Expand All

(-)a/t/db_dependent/Acquisition/OrderUsers.t (-1 / +2 lines)
Lines 17-22 my $builder = t::lib::TestBuilder->new; Link Here
17
my $library = $builder->build({
17
my $library = $builder->build({
18
    source => "Branch",
18
    source => "Branch",
19
});
19
});
20
my $patron_category = $builder->build({ source => 'Category' });
20
21
21
# Creating some orders
22
# Creating some orders
22
my $bookseller = Koha::Acquisition::Bookseller->new(
23
my $bookseller = Koha::Acquisition::Bookseller->new(
Lines 68-74 my $borrowernumber = C4::Members::AddMember( Link Here
68
    cardnumber => 'TESTCARD',
69
    cardnumber => 'TESTCARD',
69
    firstname =>  'TESTFN',
70
    firstname =>  'TESTFN',
70
    surname => 'TESTSN',
71
    surname => 'TESTSN',
71
    categorycode => 'S',
72
    categorycode => $patron_category->{categorycode},
72
    branchcode => $library->{branchcode},
73
    branchcode => $library->{branchcode},
73
    dateofbirth => '',
74
    dateofbirth => '',
74
    dateexpiry => '9999-12-31',
75
    dateexpiry => '9999-12-31',
(-)a/t/db_dependent/Circulation.t (-13 / +14 lines)
Lines 58-63 my $itemtype = $builder->build( Link Here
58
        value  => { notforloan => undef, rentalcharge => 0 }
58
        value  => { notforloan => undef, rentalcharge => 0 }
59
    }
59
    }
60
)->{itemtype};
60
)->{itemtype};
61
my $patron_category = $builder->build({ source => 'Category', value => { enrolmentfee => 0 } });
61
62
62
my $CircControl = C4::Context->preference('CircControl');
63
my $CircControl = C4::Context->preference('CircControl');
63
my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
64
my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
Lines 190-196 my $sth = C4::Context->dbh->prepare("SELECT COUNT(*) FROM accountlines WHERE amo Link Here
190
$sth->execute();
191
$sth->execute();
191
my ( $original_count ) = $sth->fetchrow_array();
192
my ( $original_count ) = $sth->fetchrow_array();
192
193
193
C4::Context->dbh->do("INSERT INTO borrowers ( cardnumber, surname, firstname, categorycode, branchcode ) VALUES ( '99999999999', 'Hall', 'Kyle', 'S', ? )", undef, $library2->{branchcode} );
194
C4::Context->dbh->do("INSERT INTO borrowers ( cardnumber, surname, firstname, categorycode, branchcode ) VALUES ( '99999999999', 'Hall', 'Kyle', ?, ? )", undef, $patron_category->{categorycode}, $library2->{branchcode} );
194
195
195
C4::Circulation::ProcessOfflinePayment({ cardnumber => '99999999999', amount => '123.45' });
196
C4::Circulation::ProcessOfflinePayment({ cardnumber => '99999999999', amount => '123.45' });
196
197
Lines 260-287 C4::Context->dbh->do("DELETE FROM accountlines"); Link Here
260
    my %renewing_borrower_data = (
261
    my %renewing_borrower_data = (
261
        firstname =>  'John',
262
        firstname =>  'John',
262
        surname => 'Renewal',
263
        surname => 'Renewal',
263
        categorycode => 'S',
264
        categorycode => $patron_category->{categorycode},
264
        branchcode => $branch,
265
        branchcode => $branch,
265
    );
266
    );
266
267
267
    my %reserving_borrower_data = (
268
    my %reserving_borrower_data = (
268
        firstname =>  'Katrin',
269
        firstname =>  'Katrin',
269
        surname => 'Reservation',
270
        surname => 'Reservation',
270
        categorycode => 'S',
271
        categorycode => $patron_category->{categorycode},
271
        branchcode => $branch,
272
        branchcode => $branch,
272
    );
273
    );
273
274
274
    my %hold_waiting_borrower_data = (
275
    my %hold_waiting_borrower_data = (
275
        firstname =>  'Kyle',
276
        firstname =>  'Kyle',
276
        surname => 'Reservation',
277
        surname => 'Reservation',
277
        categorycode => 'S',
278
        categorycode => $patron_category->{categorycode},
278
        branchcode => $branch,
279
        branchcode => $branch,
279
    );
280
    );
280
281
281
    my %restricted_borrower_data = (
282
    my %restricted_borrower_data = (
282
        firstname =>  'Alice',
283
        firstname =>  'Alice',
283
        surname => 'Reservation',
284
        surname => 'Reservation',
284
        categorycode => 'S',
285
        categorycode => $patron_category->{categorycode},
285
        debarred => '3228-01-01',
286
        debarred => '3228-01-01',
286
        branchcode => $branch,
287
        branchcode => $branch,
287
    );
288
    );
Lines 761-767 C4::Context->dbh->do("DELETE FROM accountlines"); Link Here
761
    my %a_borrower_data = (
762
    my %a_borrower_data = (
762
        firstname =>  'Fridolyn',
763
        firstname =>  'Fridolyn',
763
        surname => 'SOMERS',
764
        surname => 'SOMERS',
764
        categorycode => 'S',
765
        categorycode => $patron_category->{categorycode},
765
        branchcode => $branch,
766
        branchcode => $branch,
766
    );
767
    );
767
768
Lines 841-847 C4::Context->dbh->do("DELETE FROM accountlines"); Link Here
841
    my %a_borrower_data = (
842
    my %a_borrower_data = (
842
        firstname =>  'Kyle',
843
        firstname =>  'Kyle',
843
        surname => 'Hall',
844
        surname => 'Hall',
844
        categorycode => 'S',
845
        categorycode => $patron_category->{categorycode},
845
        branchcode => $branch,
846
        branchcode => $branch,
846
    );
847
    );
847
848
Lines 907-919 C4::Context->dbh->do("DELETE FROM accountlines"); Link Here
907
    my $borrowernumber1 = AddMember(
908
    my $borrowernumber1 = AddMember(
908
        firstname    => 'Kyle',
909
        firstname    => 'Kyle',
909
        surname      => 'Hall',
910
        surname      => 'Hall',
910
        categorycode => 'S',
911
        categorycode => $patron_category->{categorycode},
911
        branchcode   => $library2->{branchcode},
912
        branchcode   => $library2->{branchcode},
912
    );
913
    );
913
    my $borrowernumber2 = AddMember(
914
    my $borrowernumber2 = AddMember(
914
        firstname    => 'Chelsea',
915
        firstname    => 'Chelsea',
915
        surname      => 'Hall',
916
        surname      => 'Hall',
916
        categorycode => 'S',
917
        categorycode => $patron_category->{categorycode},
917
        branchcode   => $library2->{branchcode},
918
        branchcode   => $library2->{branchcode},
918
    );
919
    );
919
920
Lines 984-990 C4::Context->dbh->do("DELETE FROM accountlines"); Link Here
984
    my $borrowernumber = AddMember(
985
    my $borrowernumber = AddMember(
985
        firstname =>  'fn',
986
        firstname =>  'fn',
986
        surname => 'dn',
987
        surname => 'dn',
987
        categorycode => 'S',
988
        categorycode => $patron_category->{categorycode},
988
        branchcode => $branch,
989
        branchcode => $branch,
989
    );
990
    );
990
991
Lines 1310-1316 subtest 'MultipleReserves' => sub { Link Here
1310
    my %renewing_borrower_data = (
1311
    my %renewing_borrower_data = (
1311
        firstname =>  'John',
1312
        firstname =>  'John',
1312
        surname => 'Renewal',
1313
        surname => 'Renewal',
1313
        categorycode => 'S',
1314
        categorycode => $patron_category->{categorycode},
1314
        branchcode => $branch,
1315
        branchcode => $branch,
1315
    );
1316
    );
1316
    my $renewing_borrowernumber = AddMember(%renewing_borrower_data);
1317
    my $renewing_borrowernumber = AddMember(%renewing_borrower_data);
Lines 1323-1329 subtest 'MultipleReserves' => sub { Link Here
1323
    my %reserving_borrower_data1 = (
1324
    my %reserving_borrower_data1 = (
1324
        firstname =>  'Katrin',
1325
        firstname =>  'Katrin',
1325
        surname => 'Reservation',
1326
        surname => 'Reservation',
1326
        categorycode => 'S',
1327
        categorycode => $patron_category->{categorycode},
1327
        branchcode => $branch,
1328
        branchcode => $branch,
1328
    );
1329
    );
1329
    my $reserving_borrowernumber1 = AddMember(%reserving_borrower_data1);
1330
    my $reserving_borrowernumber1 = AddMember(%reserving_borrower_data1);
Lines 1336-1342 subtest 'MultipleReserves' => sub { Link Here
1336
    my %reserving_borrower_data2 = (
1337
    my %reserving_borrower_data2 = (
1337
        firstname =>  'Kirk',
1338
        firstname =>  'Kirk',
1338
        surname => 'Reservation',
1339
        surname => 'Reservation',
1339
        categorycode => 'S',
1340
        categorycode => $patron_category->{categorycode},
1340
        branchcode => $branch,
1341
        branchcode => $branch,
1341
    );
1342
    );
1342
    my $reserving_borrowernumber2 = AddMember(%reserving_borrower_data2);
1343
    my $reserving_borrowernumber2 = AddMember(%reserving_borrower_data2);
(-)a/t/db_dependent/Circulation/IsItemIssued.t (-1 / +2 lines)
Lines 37-42 my $builder = t::lib::TestBuilder->new; Link Here
37
37
38
my $library = $builder->build({ source => 'Branch' });
38
my $library = $builder->build({ source => 'Branch' });
39
my $itemtype = $builder->build({ source => 'Itemtype' })->{itemtype};
39
my $itemtype = $builder->build({ source => 'Itemtype' })->{itemtype};
40
my $patron_category = $builder->build({ source => 'Category' });
40
41
41
C4::Context->_new_userenv('DUMMY SESSION');
42
C4::Context->_new_userenv('DUMMY SESSION');
42
C4::Context->set_userenv(
43
C4::Context->set_userenv(
Lines 50-56 C4::Context->set_userenv( Link Here
50
my $borrowernumber = AddMember(
51
my $borrowernumber = AddMember(
51
    firstname =>  'my firstname',
52
    firstname =>  'my firstname',
52
    surname => 'my surname',
53
    surname => 'my surname',
53
    categorycode => 'S',
54
    categorycode => $patron_category->{categorycode},
54
    branchcode => $library->{branchcode},
55
    branchcode => $library->{branchcode},
55
);
56
);
56
57
(-)a/t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t (-1 / +2 lines)
Lines 23-28 $dbh->{RaiseError} = 1; Link Here
23
23
24
my $branchcode = $builder->build({ source => 'Branch' })->{branchcode};
24
my $branchcode = $builder->build({ source => 'Branch' })->{branchcode};
25
my $itemtype   = $builder->build({ source => 'Itemtype' })->{itemtype};
25
my $itemtype   = $builder->build({ source => 'Itemtype' })->{itemtype};
26
my $patron_category = $builder->build({ source => 'Category' });
26
27
27
local $SIG{__WARN__} = sub { warn $_[0] unless $_[0] =~ /redefined/ };
28
local $SIG{__WARN__} = sub { warn $_[0] unless $_[0] =~ /redefined/ };
28
my $userenv->{branch} = $branchcode;
29
my $userenv->{branch} = $branchcode;
Lines 47-53 $builder->build( Link Here
47
my $borrowernumber = AddMember(
48
my $borrowernumber = AddMember(
48
    firstname =>  'my firstname',
49
    firstname =>  'my firstname',
49
    surname => 'my surname',
50
    surname => 'my surname',
50
    categorycode => 'S',
51
    categorycode => $patron_category->{categorycode},
51
    branchcode => $branchcode,
52
    branchcode => $branchcode,
52
);
53
);
53
my $borrower = GetMember( borrowernumber => $borrowernumber );
54
my $borrower = GetMember( borrowernumber => $borrowernumber );
(-)a/t/db_dependent/Holds/HoldFulfillmentPolicy.t (-1 lines)
Lines 33-39 my $bib_title = "Test Title"; Link Here
33
my $borrower = $builder->build({
33
my $borrower = $builder->build({
34
    source => 'Borrower',
34
    source => 'Borrower',
35
    value => {
35
    value => {
36
        categorycode => 'S',
37
        branchcode => $library1->{branchcode},
36
        branchcode => $library1->{branchcode},
38
    }
37
    }
39
});
38
});
(-)a/t/db_dependent/Holds/HoldItemtypeLimit.t (-1 / +1 lines)
Lines 26-35 my $library = $builder->build({ Link Here
26
26
27
my $bib_title = "Test Title";
27
my $bib_title = "Test Title";
28
28
29
29
my $borrower = $builder->build({
30
my $borrower = $builder->build({
30
    source => 'Borrower',
31
    source => 'Borrower',
31
    value => {
32
    value => {
32
        categorycode => 'S',
33
        branchcode => $library->{branchcode},
33
        branchcode => $library->{branchcode},
34
    }
34
    }
35
});
35
});
(-)a/t/db_dependent/Holds/LocalHoldsPriority.t (-7 / +3 lines)
Lines 53-68 my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem( Link Here
53
53
54
my @branchcodes = ( $library1->{branchcode}, $library2->{branchcode}, $library3->{branchcode}, $library4->{branchcode}, $library3->{branchcode}, $library4->{branchcode} );
54
my @branchcodes = ( $library1->{branchcode}, $library2->{branchcode}, $library3->{branchcode}, $library4->{branchcode}, $library3->{branchcode}, $library4->{branchcode} );
55
55
56
my $patron_category = $builder->build({ source => 'Category' });
56
# Create some borrowers
57
# Create some borrowers
57
my @borrowernumbers;
58
my @borrowernumbers;
58
foreach ( 1 .. $borrowers_count ) {
59
foreach ( 1 .. $borrowers_count ) {
59
    my $borrowernumber = AddMember(
60
    my $patron = $builder->build({ class => 'Borrower', value => branchcode => $branchcodes[$_]});
60
        firstname    => 'my firstname',
61
    push @borrowernumbers, $patron->{borrowernumber};
61
        surname      => 'my surname ' . $_,
62
        categorycode => 'S',
63
        branchcode   => $branchcodes[$_],
64
    );
65
    push @borrowernumbers, $borrowernumber;
66
}
62
}
67
63
68
my $biblionumber = $bibnum;
64
my $biblionumber = $bibnum;
(-)a/t/db_dependent/Holds/RevertWaitingStatus.t (-1 / +2 lines)
Lines 69-80 my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem( Link Here
69
);
69
);
70
70
71
# Create some borrowers
71
# Create some borrowers
72
my $patron_category = $builder->build({ source => 'Category' });
72
my @borrowernumbers;
73
my @borrowernumbers;
73
foreach my $i ( 1 .. $borrowers_count ) {
74
foreach my $i ( 1 .. $borrowers_count ) {
74
    my $borrowernumber = AddMember(
75
    my $borrowernumber = AddMember(
75
        firstname    => 'my firstname',
76
        firstname    => 'my firstname',
76
        surname      => 'my surname ' . $i,
77
        surname      => 'my surname ' . $i,
77
        categorycode => 'S',
78
        categorycode => $patron_category->{categorycode},
78
        branchcode   => $branchcode,
79
        branchcode   => $branchcode,
79
    );
80
    );
80
    push @borrowernumbers, $borrowernumber;
81
    push @borrowernumbers, $borrowernumber;
(-)a/t/db_dependent/Members/Attributes.t (-2 lines)
Lines 48-54 my $patron = $builder->build( Link Here
48
        value  => {
48
        value  => {
49
            firstname    => 'my firstname',
49
            firstname    => 'my firstname',
50
            surname      => 'my surname',
50
            surname      => 'my surname',
51
            categorycode => 'S',
52
            branchcode => $library->{branchcode},
51
            branchcode => $library->{branchcode},
53
        }
52
        }
54
    }
53
    }
Lines 228-234 my $another_patron = $builder->build( Link Here
228
        value  => {
227
        value  => {
229
            firstname    => 'my another firstname',
228
            firstname    => 'my another firstname',
230
            surname      => 'my another surname',
229
            surname      => 'my another surname',
231
            categorycode => 'S',
232
            branchcode => $new_library->{branchcode},
230
            branchcode => $new_library->{branchcode},
233
        }
231
        }
234
    }
232
    }
(-)a/t/db_dependent/Patron/Borrower_Debarments.t (-1 / +2 lines)
Lines 22-31 my $library = $builder->build({ Link Here
22
    source => 'Branch',
22
    source => 'Branch',
23
});
23
});
24
24
25
my $patron_category = $builder->build({ source => 'Category' });
25
my $borrowernumber = AddMember(
26
my $borrowernumber = AddMember(
26
    firstname =>  'my firstname',
27
    firstname =>  'my firstname',
27
    surname => 'my surname',
28
    surname => 'my surname',
28
    categorycode => 'S',
29
    categorycode => $patron_category->{categorycode},
29
    branchcode => $library->{branchcode},
30
    branchcode => $library->{branchcode},
30
);
31
);
31
32
(-)a/t/db_dependent/Patron/Borrower_Files.t (-1 / +2 lines)
Lines 42-51 my $library = $builder->build({ Link Here
42
    source => 'Branch',
42
    source => 'Branch',
43
});
43
});
44
44
45
my $patron_category = $builder->build({ source => 'Category' });
45
my $borrowernumber = AddMember(
46
my $borrowernumber = AddMember(
46
    firstname =>  'my firstname',
47
    firstname =>  'my firstname',
47
    surname => 'my surname',
48
    surname => 'my surname',
48
    categorycode => 'S',
49
    categorycode => $patron_category->{categorycode},
49
    branchcode => $library->{branchcode},
50
    branchcode => $library->{branchcode},
50
);
51
);
51
52
(-)a/t/db_dependent/Serials_2.t (-2 / +2 lines)
Lines 27-32 my $library1 = $builder->build({ Link Here
27
my $library2 = $builder->build({
27
my $library2 = $builder->build({
28
    source => 'Branch',
28
    source => 'Branch',
29
});
29
});
30
my $patron_category = $builder->build({ source => 'Category' });
30
my $dbh = C4::Context->dbh;
31
my $dbh = C4::Context->dbh;
31
$dbh->{RaiseError} = 1;
32
$dbh->{RaiseError} = 1;
32
33
Lines 81-87 my $userid = 'my_userid'; Link Here
81
my $borrowernumber = C4::Members::AddMember(
82
my $borrowernumber = C4::Members::AddMember(
82
    firstname =>  'my fistname',
83
    firstname =>  'my fistname',
83
    surname => 'my surname',
84
    surname => 'my surname',
84
    categorycode => 'S',
85
    categorycode => $patron_category->{categorycode},
85
    branchcode => $my_branch,
86
    branchcode => $my_branch,
86
    userid => $userid,
87
    userid => $userid,
87
);
88
);
88
- 

Return to bug 18420