Bugzilla – Attachment 62801 Details for
Bug 3311
Statistical reports should error if row and column aren't selected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 3311: Issues stat report row and column required
Bug-3311-Issues-stat-report-row-and-column-require.patch (text/plain), 2.47 KB, created by
Mark Tompsett
on 2017-04-27 18:39:37 UTC
(
hide
)
Description:
Bug 3311: Issues stat report row and column required
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-04-27 18:39:37 UTC
Size:
2.47 KB
patch
obsolete
>From d3fc6f4c4fa1923a75078b064008f3800dc94871 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Thu, 27 Apr 2017 13:41:44 -0400 >Subject: [PATCH] Bug 3311: Issues stat report row and column required > >--- > .../intranet-tmpl/prog/en/modules/reports/issues_stats.tt | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >index ea7c184..3ebfac8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >@@ -3,6 +3,7 @@ > <title>Koha › Reports › Circulation statistics [% IF ( do_it ) %]› Results[% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] > [% INCLUDE 'calendar.inc' %] >+<script type="text/javascript" src="[% themelang %]/js/row-columns-require.js"></script> > <style type="text/css"> > .sql {display:none;} > </style> >@@ -85,22 +86,26 @@ > [% END %] > [% ELSE %] > >- <form method="post" action="/cgi-bin/koha/reports/issues_stats.pl"> >+ <form name="configure_report" id="configure_report" method="post" action="/cgi-bin/koha/reports/issues_stats.pl"> > <fieldset class="rows"> > <legend>Circulation statistics</legend><table> > <thead> > <tr> > <th>Title</th> >- <th>Row</th> >- <th>Column</th> >+ <th class="required">Row<br> >+ <span id="LineError"></span> >+ </th> >+ <th class="required">Column<br> >+ <span id="ColumnError"></span> >+ </th> > <th>Filter</th> > </tr> > </thead> > <tbody> > <tr> > <td>Period</td> >- <td><input type="radio" name="Line" value="datetime" /></td> >- <td><input type="radio" name="Column" value="datetime" /></td> >+ <td><input type="radio" name="Line" required value="datetime" /></td> >+ <td><input type="radio" name="Column" required value="datetime" /></td> > <td><label for="from">From</label> <input type="text" size="10" id="from" name="Filter" class="datepickerfrom" /> > <label for="to">To</label> <input size="10" id="to" name="Filter" value="" type="text" class="datepickerto" /> > <span class="hint">[% INCLUDE 'date-format.inc' %]</span> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3311
:
52775
|
52776
|
52777
|
52778
|
52779
|
53194
|
53195
|
53291
|
62533
|
62541
|
62623
|
62624
|
62630
|
62658
|
62659
|
62776
|
62777
|
62793
|
62794
|
62795
|
62796
|
62797
|
62798
|
62799
|
62800
| 62801 |
62802