Bugzilla – Attachment 63105 Details for
Bug 13913
Renewal error message in OPAC is confusing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13913 - Renewal error message in OPAC is confusing
Bug-13913---Renewal-error-message-in-OPAC-is-confu.patch (text/plain), 3.53 KB, created by
Owen Leonard
on 2017-05-04 14:04:22 UTC
(
hide
)
Description:
Bug 13913 - Renewal error message in OPAC is confusing
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2017-05-04 14:04:22 UTC
Size:
3.53 KB
patch
obsolete
>From 461c514e0d0368c84bd7ec24cc86bdd45a1972df Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Sat, 29 Apr 2017 17:14:10 +0000 >Subject: [PATCH] Bug 13913 - Renewal error message in OPAC is confusing > >This patch adds some formatting to the error message a patron receives >when there are renewal failures in the OPAC. > >This is pretty much the least which could be done to address this >problem. However, I don't think the issue can be fixed without >re-thinking how renewals are processed. Sending error messages back to >opac-user.pl via URL parameter isn't flexible enough. > >To test, apply the patch and attempt to renew multiple items in the OPAC >which cannot be renewed for some reason, for instance because they have >been renewed too many times. The error messages should appear in a list >rather than strung together in one long block of text. >--- > .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 24 +++++++++++----------- > 1 file changed, 12 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index cded80d..acd83ae 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -75,20 +75,20 @@ Using this account is not recommended because some parts of Koha will not functi > [% IF ( RENEW_ERROR ) %] > <div class="dialog alert"> > <strong>Please note:</strong> >- <span> > Your loan renewal failed because of the following reason(s): >- [% FOREACH error IN RENEW_ERROR.split('\|') %] >- [% IF error == 'card_expired' %] >- Your account has expired. Please contact the library for more information. >- [% ELSIF error == 'too_many' %] >- You have renewed this item the maximum number of times allowed. >- [% ELSIF error == 'too_soon' %] >- It is too soon after the checkout date for this item to be renewed. >- [% ELSIF error == 'on_reserve' %] >- This item is on hold for another borrower. >+ <ul> >+ [% FOREACH error IN RENEW_ERROR.split('\|') %] >+ [% IF error == 'card_expired' %] >+ <li>Your account has expired. Please contact the library for more information.</li> >+ [% ELSIF error == 'too_many' %] >+ <li>You have renewed this item the maximum number of times allowed.</li> >+ [% ELSIF error == 'too_soon' %] >+ <li>It is too soon after the checkout date for this item to be renewed.</li> >+ [% ELSIF error == 'on_reserve' %] >+ <li>This item is on hold for another borrower.</li> >+ [% END %] > [% END %] >- [% END %] >- </span> >+ </ul> > </div> > [% END %] > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13913
:
37266
|
63105
|
63321
|
63922