View | Details | Raw Unified | Return to bug 11999
Collapse All | Expand All

(-)a/C4/Reserves.pm (-8 / +1 lines)
Lines 325-339 See CanItemBeReserved() for possible return values. Link Here
325
sub CanBookBeReserved{
325
sub CanBookBeReserved{
326
    my ($borrowernumber, $biblionumber) = @_;
326
    my ($borrowernumber, $biblionumber) = @_;
327
327
328
    # Check if borrower already has reserved the same biblio.
329
    my @reserves = GetReservesFromBorrowernumber($borrowernumber);
330
    foreach my $reserve (@reserves) {
331
        if ($reserve->{biblionumber} == $biblionumber) {
332
            return 'alreadyReserved';
333
        }
334
    }
335
336
    # Check if borrower has reached the maximum number of holds allowed
328
    # Check if borrower has reached the maximum number of holds allowed
329
    my @reserves = GetReservesFromBorrowernumber($borrowernumber);
337
    my $maxreserves = C4::Context->preference('maxreserves');
330
    my $maxreserves = C4::Context->preference('maxreserves');
338
    if ($maxreserves && scalar(@reserves) >= $maxreserves) {
331
    if ($maxreserves && scalar(@reserves) >= $maxreserves) {
339
        return 'tooManyReserves';
332
        return 'tooManyReserves';
(-)a/t/db_dependent/Holds.t (-3 / +2 lines)
Lines 397-406 ok( Link Here
397
    "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
397
    "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
398
);
398
);
399
399
400
is(CanBookBeReserved($borrowernumbers[0], $bibnum), 'alreadyReserved');
400
is(CanBookBeReserved($borrowernumbers[0], $bibnum), 'none_available');
401
401
402
C4::Context->set_preference('maxreserves', 1);
402
C4::Context->set_preference('maxreserves', 1);
403
ok(CanBookBeReserved($borrowernumbers[0], $biblionumber) eq 'tooManyReserves');
403
is(CanBookBeReserved($borrowernumbers[0], $biblionumber), 'tooManyReserves');
404
404
405
C4::Context->set_preference('maxreserves', 0);
405
C4::Context->set_preference('maxreserves', 0);
406
t::lib::Mocks::mock_preference('IndependentBranches', 1);
406
t::lib::Mocks::mock_preference('IndependentBranches', 1);
407
- 

Return to bug 11999