From d9c66ee8c0fb415ee3f279833855c910853c1401 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 26 May 2017 10:20:00 +0200 Subject: [PATCH] Bug 18611: [QA Follow-up] Make SQL query more readable Content-Type: text/plain; charset=utf-8 Make it more explicit by adding join statements. Test plan: See next patch for adding a unit test. Signed-off-by: Marcel de Rooy --- C4/ImportBatch.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm index 4ac5618..1b598c7 100644 --- a/C4/ImportBatch.pm +++ b/C4/ImportBatch.pm @@ -1059,7 +1059,12 @@ sub GetImportBatchRangeDesc { sub GetItemNumbersFromImportBatch { my ($batch_id) = @_; my $dbh = C4::Context->dbh; - my $sth = $dbh->prepare("SELECT items.itemnumber FROM import_batches,import_records,import_items, items WHERE import_batches.import_batch_id=import_records.import_batch_id AND import_records.import_record_id=import_items.import_record_id AND items.itemnumber=import_items.itemnumber AND import_batches.import_batch_id=?"); + my $sql = q| +SELECT itemnumber FROM import_items +INNER JOIN items USING (itemnumber) +INNER JOIN import_records USING (import_record_id) +WHERE import_batch_id = ?|; + my $sth = $dbh->prepare( $sql ); $sth->execute($batch_id); my @items ; while ( my ($itm) = $sth->fetchrow_array ) { -- 2.1.4