Bugzilla – Attachment 63737 Details for
Bug 18478
Some notices sent via SMS gateway fail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18478 - QA Followup
Bug-18478---QA-Followup.patch (text/plain), 2.47 KB, created by
Marcel de Rooy
on 2017-05-26 09:34:24 UTC
(
hide
)
Description:
Bug 18478 - QA Followup
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-05-26 09:34:24 UTC
Size:
2.47 KB
patch
obsolete
>From 41e2a1ccc8bc302cd86ee84ff5cd72f2506d83d8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 23 May 2017 16:11:06 -0400 >Subject: [PATCH] Bug 18478 - QA Followup >Content-Type: text/plain; charset=utf-8 > >Make sure to build necessary letters >Fix awkward construction > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Letters.pm | 2 +- > t/db_dependent/Reserves.t | 20 ++++++++++++++++++-- > 2 files changed, 19 insertions(+), 3 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index e0aaafe..cd7b785 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -1054,7 +1054,7 @@ sub SendQueuedMessages { > _set_message_status( { message_id => $message->{'message_id'}, status => 'failed' } ); > next MESSAGE; > } >- $message->{to_address} = $message->{to_address} ? $message->{to_address} : $member->{'smsalertnumber'}; >+ $message->{to_address} ||= $member->{'smsalertnumber'}; > unless ( $message->{to_address} && $member->{'smsalertnumber'} ) { > _set_message_status( { message_id => $message->{'message_id'}, status => 'failed' } ); > warn sprintf( "No smsalertnumber found for patron %s!", $message->{'borrowernumber'} ) if $params->{'verbose'} or $debug; >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index 0ac07f3..1a2d33c 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -733,14 +733,30 @@ subtest '_koha_notify_reserve() tests' => sub { > }; > > my $mp = Test::MockModule->new( 'C4::Members::Messaging' ); >+ > $mp->mock("GetMessagingPreferences",$wants_hold_and_email); > >- my $sms_hold_notice = $builder->build_object({ >- class => 'Koha::Notice::Templates', >+ $dbh->do('DELETE FROM letter'); >+ >+ my $email_hold_notice = $builder->build({ >+ source => 'Letter', >+ value => { >+ message_transport_type => 'email', >+ branchcode => '', >+ code => 'HOLD', >+ module => 'reserves', >+ lang => 'default', >+ } >+ }); >+ >+ my $sms_hold_notice = $builder->build({ >+ source => 'Letter', > value => { > message_transport_type => 'sms', > branchcode => '', > code => 'HOLD', >+ module => 'reserves', >+ lang=>'default', > } > }); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18478
:
63487
|
63488
|
63504
|
63505
|
63506
|
63674
|
63675
|
63734
|
63735
|
63736
| 63737 |
63738
|
63983
|
63984
|
63985