Bugzilla – Attachment 64011 Details for
Bug 18226
Remove "use Test::DBIx::Class" instantiations' dangerous code duplication
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18226: [QA Follow-up] Remove further assumptions on branch count
Bug-18226-QA-Follow-up-Remove-further-assumptions-.patch (text/plain), 1.89 KB, created by
Jonathan Druart
on 2017-06-05 20:55:03 UTC
(
hide
)
Description:
Bug 18226: [QA Follow-up] Remove further assumptions on branch count
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-06-05 20:55:03 UTC
Size:
1.89 KB
patch
obsolete
>From 263c1e500f78df364b8c88a19619194158f74040 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 24 May 2017 14:10:29 +0200 >Subject: [PATCH] Bug 18226: [QA Follow-up] Remove further assumptions on > branch count > >See also follow-up on bug 18286. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/01-test_dbic.t | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/01-test_dbic.t b/t/db_dependent/01-test_dbic.t >index c3d972797c..0312120d0e 100644 >--- a/t/db_dependent/01-test_dbic.t >+++ b/t/db_dependent/01-test_dbic.t >@@ -38,8 +38,7 @@ subtest "Scenario: Show how caching prevents Test::DBIx::Class from working prop > ok(1, > 'Step: Given Test::DBIx::Class (T:D:C) is loaded and DB accessor is mocked. Connection from cache is still used.'); > >- ok($libCount = Koha::Libraries->search->count, >- ' When the libraries are counted'); >+ $libCount = Koha::Libraries->search->count; > > is($libCount, $firstLibCount, > ' Then we got the same count as without T:D:C'); >@@ -55,8 +54,7 @@ subtest "Scenario: Show how caching prevents Test::DBIx::Class from working prop > ok(Koha::Database::flush_schema_cache(), > 'Step: Given the DB connection cache is flushed'); > >- ok(! ($libCount = Koha::Libraries->search->count), >- ' When the libraries are counted'); >+ $libCount = Koha::Libraries->search->count; > > is($libCount, 0, > ' Then we got 0 libraries because fixtures are not deployed'); >@@ -77,8 +75,7 @@ subtest "Scenario: Show how caching prevents Test::DBIx::Class from working prop > ], > 'Step: Given we deploy T:D:C Fixtures'); > >- ok($libCount = Koha::Libraries->search->count, >- ' When the libraries are counted'); >+ $libCount = Koha::Libraries->search->count; > > is($libCount, 1, > ' Then we got the count from fixtures'); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18226
:
60885
|
60886
|
60920
|
60923
|
62960
|
62961
|
62962
|
62968
|
62969
|
62970
|
63688
|
63689
|
63999
|
64008
|
64009
|
64010
| 64011 |
64012
|
64013