From 65e87bdb6ab4bc9110dfca8fea88011db5b4fc2a Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Fri, 2 Jun 2017 04:30:42 +0000 Subject: [PATCH] Bug 12145: [FOLLOW-UP] Separating buttons and tags This patch fixes the issue in Comment 2. The move-up buttons were inside the element that gets hidden when 'Show tags' is off, therefore removing their functionality and making the 'Lock subfield positions' button useless. This patch separates the buttons and the tags into two separate span elements, and adds the appropriate CSS. To test: Confirm that 'Lock subfield positions' still works when 'Show tags' is off. Signed-off-by: Eugene Jose Espinoza for KohaCon2017 --- koha-tmpl/intranet-tmpl/prog/css/addbiblio.css | 7 ++++++- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 6 ++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css index f49eb61..924449e 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css +++ b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css @@ -49,7 +49,7 @@ div.subfield_line label { clear:left; } -.subfieldcode img { +.subfieldmoveup img { cursor: pointer; } @@ -80,6 +80,11 @@ a.tagnum { text-align:right; } +.subfieldmoveup { + display: block; + float: left; +} + .subfieldcode { display: block; float: left; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt index 0f6a821..26b5c2f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt @@ -656,12 +656,14 @@ function Changefwk() { [% END %] [% END %] - + [% IF ( subfield_loo.fixedfield ) %] [% ELSE %] Move Up [% END %] + + - + [% UNLESS advancedMARCEditor %] [% IF ( subfield_loo.mandatory ) %][% ELSE %][% END %] -- 2.7.4