From 2ba94722a966f8659ff1eeadd2b9ac6912b36d3d Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Mon, 12 Jun 2017 12:28:31 +0200 Subject: [PATCH] [SIGNED-OFF] Bug 18782: Remove unused C4::Serials::getsupplierbyserialid TEST PLAN ---------- git grep -i getsupplierby -- only the code removed and the test tweaked git bz apply 18782 sudo koha-shell -c bash kohadev prove -v t/db_dependent/Serials.t qa -v 2 c 1 exit -- sign off Signed-off-by: Mark Tompsett --- C4/Serials.pm | 29 +---------------------------- t/db_dependent/Serials.t | 4 +--- 2 files changed, 2 insertions(+), 31 deletions(-) diff --git a/C4/Serials.pm b/C4/Serials.pm index 177bc76502..4b9ac61ba0 100644 --- a/C4/Serials.pm +++ b/C4/Serials.pm @@ -78,7 +78,7 @@ BEGIN { &PrepareSerialsData &GetNextExpected &ModNextExpected &GetPreviousSerialid - &GetSuppliersWithLateIssues &getsupplierbyserialid + &GetSuppliersWithLateIssues &GetDistributedTo &SetDistributedTo &getroutinglist &delroutingmember &addroutingmember &reorder_members @@ -1920,33 +1920,6 @@ sub updateClaim { {}, CLAIMED, @$serialids ); } -=head2 getsupplierbyserialid - -$result = getsupplierbyserialid($serialid) - -this function is used to find the supplier id given a serial id - -return : -hashref containing serialid, subscriptionid, and aqbooksellerid - -=cut - -sub getsupplierbyserialid { - my ($serialid) = @_; - my $dbh = C4::Context->dbh; - my $sth = $dbh->prepare( - "SELECT serialid, serial.subscriptionid, aqbooksellerid - FROM serial - LEFT JOIN subscription ON serial.subscriptionid = subscription.subscriptionid - WHERE serialid = ? - " - ); - $sth->execute($serialid); - my $line = $sth->fetchrow_hashref; - my $result = $line->{'aqbooksellerid'}; - return $result; -} - =head2 check_routing $result = &check_routing($subscriptionid) diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t index be7f010084..de623fe731 100755 --- a/t/db_dependent/Serials.t +++ b/t/db_dependent/Serials.t @@ -18,7 +18,7 @@ use Koha::DateUtils; use Koha::Acquisition::Booksellers; use t::lib::Mocks; use t::lib::TestBuilder; -use Test::More tests => 49; +use Test::More tests => 48; BEGIN { use_ok('C4::Serials'); @@ -265,8 +265,6 @@ subtest 'test_updateClaim' => sub { is($late_or_missing_issues_1_2[0]->{status}, 3, 'Got the expected unchanged claim status from update claim'); }; -is(C4::Serials::getsupplierbyserialid(),undef, 'test getting supplier idea'); - is(C4::Serials::check_routing(), undef, 'test checking route'); is(C4::Serials::addroutingmember(),undef, 'test adding route member'); -- 2.11.0