From bfd13b70ae785f4c22ece3dbb48314b547dd666e Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 7 Aug 2017 15:02:10 +0200 Subject: [PATCH] Bug 10306: Do not allow changes to kohafield within MARC frameworks Content-Type: text/plain; charset=utf-8 This patch makes two changes to support making the Default authoritative as for Koha to MARC mappings: [1] Disable the kohafield select combo. Add a hidden input to save value. [2] When a new subfield is added, the kohafield is still empty and should be overwritten with its Default counterpart. Test plan: [1] Add a new tag and subfield in Default. [2] Map it to a kohafield in koha2marclinks.pl [3] Add the same tag and subfield in another framework. Verify that the kohafield is updated after you saved the subfield. --- admin/marc_subfields_structure.pl | 4 ++++ .../intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/admin/marc_subfields_structure.pl b/admin/marc_subfields_structure.pl index 077a58b..0f61e22 100755 --- a/admin/marc_subfields_structure.pl +++ b/admin/marc_subfields_structure.pl @@ -310,6 +310,10 @@ elsif ( $op eq 'add_validate' ) { ), ); } else { + if( my $rs = Koha::MarcSubfieldStructures->search({ frameworkcode => q{}, tagfield => $tagfield, tagsubfield => $tagsubfield }) ) { + # Overwrite empty kohafield from Default + $kohafield = $rs->next->kohafield; + } $sth_insert->execute( $tagfield, $tagsubfield, diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt index efdac8d..65d8624 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt @@ -143,7 +143,8 @@
  • (e.g., Title or Local-Number) NOTE: If you change this value you must ask your administrator to run misc/batchRebuildBiblioTables.pl.
  • - [% FOREACH value IN loo.kohafields %] [% IF ( value == loo.kohafield ) %] @@ -152,6 +153,8 @@ [% END %] [% END %] + +
  • -- 2.1.4