Bugzilla – Attachment 65841 Details for
Bug 19073
Can't change library with patron batch modification tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19073: (bug 15758 follow-up) Dereference correct value from Koha::Object.
Bug-19073-bug-15758-follow-up-Dereference-correct-.patch (text/plain), 1.51 KB, created by
Jonathan Druart
on 2017-08-10 18:28:05 UTC
(
hide
)
Description:
Bug 19073: (bug 15758 follow-up) Dereference correct value from Koha::Object.
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-08-10 18:28:05 UTC
Size:
1.51 KB
patch
obsolete
>From b59f26261fb43925af66fe2085de5b7029163223 Mon Sep 17 00:00:00 2001 >From: Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> >Date: Thu, 10 Aug 2017 13:00:19 +0200 >Subject: [PATCH] Bug 19073: (bug 15758 follow-up) Dereference correct value > from Koha::Object. > >* tools/modborrowers.pl: Dereference 'branchcode' rather than > 'value'. > >Test Plan: >- Carry out "Batch patron modification" with any number of patrons. > + Change the library. > + Hit Save. >- The library will not have been updated. >- Apply patch. >- Run same modification. >- The library will have been updated > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > tools/modborrowers.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl >index 3b83f2bb35..5c8e1b61c2 100755 >--- a/tools/modborrowers.pl >+++ b/tools/modborrowers.pl >@@ -148,7 +148,7 @@ if ( $op eq 'show' ) { > # Construct drop-down list values > my $branches = Koha::Libraries->search({}, { order_by => ['branchname'] })->unblessed; > my @branches_option; >- push @branches_option, { value => $_->{value}, lib => $_->{branchname} } for @$branches; >+ push @branches_option, { value => $_->{branchcode}, lib => $_->{branchname} } for @$branches; > unshift @branches_option, { value => "", lib => "" }; > my @categories_option; > push @categories_option, { value => $_->categorycode, lib => $_->description } for @patron_categories; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19073
:
65799
|
65801
|
65805
| 65841