Bugzilla – Attachment 66783 Details for
Bug 19059
Move C4::Reserves::CancelReserve to the Koha::Hold->cancel
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19059: Fix compilation issues
Bug-19059-Fix-compilation-issues.patch (text/plain), 2.15 KB, created by
Jonathan Druart
on 2017-09-01 19:53:10 UTC
(
hide
)
Description:
Bug 19059: Fix compilation issues
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-09-01 19:53:10 UTC
Size:
2.15 KB
patch
obsolete
>From e61db6b4b0a89df5573d9c2e5ee316b6f8a073fd Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 1 Sep 2017 16:50:26 -0300 >Subject: [PATCH] Bug 19059: Fix compilation issues > >--- > C4/Reserves.pm | 1 - > circ/branchtransfers.pl | 4 ++-- > t/db_dependent/Circulation.t | 2 +- > 3 files changed, 3 insertions(+), 4 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 079fb39..39153bb 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -799,7 +799,6 @@ sub CancelExpiredReserves { > my $dbh = C4::Context->dbh; > > my $dtf = Koha::Database->new->schema->storage->datetime_parser; >- my $today = dt_from_string; > # FIXME To move to Koha::Holds->search_expired (?) > my $holds = Koha::Holds->search( > { >diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl >index bdb007f..c1d30cb 100755 >--- a/circ/branchtransfers.pl >+++ b/circ/branchtransfers.pl >@@ -82,7 +82,7 @@ my $ignoreRs = 0; > # Deal with the requests.... > if ( $request eq "KillWaiting" ) { > my $item = $query->param('itemnumber'); >- my $holds = Koha::Holds->search( >+ my $holds = Koha::Holds->search({ > itemnumber => $item, > borrowernumber => $borrowernumber > }); >@@ -101,7 +101,7 @@ elsif ( $request eq "SetWaiting" ) { > } > elsif ( $request eq 'KillReserved' ) { > my $biblionumber = $query->param('biblionumber'); >- my $holds = Koha::Holds->search( >+ my $holds = Koha::Holds->search({ > biblionumber => $biblionumber, > borrowernumber => $borrowernumber > }); >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 4ed1e78..34728d3 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -516,7 +516,7 @@ C4::Context->dbh->do("DELETE FROM accountlines"); > is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue'); > > >- my $hold = Koha::Holds->search({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber })->next; >+ $hold = Koha::Holds->search({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber })->next; > $hold->cancel; > > # Bug 14101 >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19059
:
65607
|
65608
|
65609
|
65610
|
65611
|
65630
|
65631
|
65632
|
65633
|
65634
|
65636
|
65637
|
65638
|
65639
|
65640
|
66783
|
66930
|
66975
|
66976
|
66977
|
66978
|
66979
|
66980
|
66981