Bugzilla – Attachment 67668 Details for
Bug 19315
Routing preview may use wrong biblionumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19315 - Use bibnum instead of biblionumber in routing-preview.pl and add item check
Bug-19315---Use-bibnum-instead-of-biblionumber-in-.patch (text/plain), 1.88 KB, created by
Marcel de Rooy
on 2017-10-06 06:25:45 UTC
(
hide
)
Description:
Bug 19315 - Use bibnum instead of biblionumber in routing-preview.pl and add item check
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-10-06 06:25:45 UTC
Size:
1.88 KB
patch
obsolete
>From f1a3d21ef463f7bd8a5c63dab4b6a07d979b32e8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 14 Sep 2017 12:23:09 +0000 >Subject: [PATCH] Bug 19315 - Use bibnum instead of biblionumber in > routing-preview.pl and add item check >Content-Type: text/plain; charset=utf-8 > >To test: > 1 - Create a serial subscription attached to a record > 2 - Receive some issues > 3 - Edit the subscription > 4 - Go to serails collection > 5 - Try to print a routing list > 6 - You may or may not get the right serial > 7 - Additionally create a subscription attached to a bib with no items > 8 - Try to print a routing list for this serial > 9 - You will get 'Internal server error' >10 - Apply patch >11 - Print routing list for first serial >12 - You will always get the correct bib >13 - Print routing list for second serial >14 - You should no longer get an error > >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > serials/routing-preview.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/serials/routing-preview.pl b/serials/routing-preview.pl >index 73d89df..5685b0f 100755 >--- a/serials/routing-preview.pl >+++ b/serials/routing-preview.pl >@@ -65,10 +65,10 @@ my ($template, $loggedinuser, $cookie); > > if($ok){ > # get biblio information.... >- my $biblionumber = $subs->{'biblionumber'}; >+ my $biblionumber = $subs->{'bibnum'}; > my ($count2,@bibitems) = GetBiblioItemByBiblioNumber($biblionumber); >- my @itemresults = GetItemsInfo( $subs->{biblionumber} ); >- my $branch = $itemresults[0]->{'holdingbranch'}; >+ my @itemresults = GetItemsInfo( $subs->{bibnum} ); >+ my $branch = scalar @itemresults ? $itemresults[0]->{'holdingbranch'} : $subs->{branchcode}; > my $branchname = Koha::Libraries->find($branch)->branchname; > > if (C4::Context->preference('RoutingListAddReserves')){ >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19315
:
67134
|
67164
| 67668 |
67669
|
70022
|
70026
|
70027
|
70028
|
70044
|
70045
|
70046