Bugzilla – Attachment 70135 Details for
Bug 19760
Die instead of warn if koha-conf is not accessible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19760: Fix Config.t test
Bug-19760-Fix-Configt-test.patch (text/plain), 996 bytes, created by
Jonathan Druart
on 2017-12-22 17:05:29 UTC
(
hide
)
Description:
Bug 19760: Fix Config.t test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-12-22 17:05:29 UTC
Size:
996 bytes
patch
obsolete
>From 8592be20367790582c7235988ceafc5350a036b3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 22 Dec 2017 14:04:52 -0300 >Subject: [PATCH] Bug 19760: Fix Config.t test > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/Koha/Config.t | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/t/Koha/Config.t b/t/Koha/Config.t >index 2ae3c25..b4168b9 100644 >--- a/t/Koha/Config.t >+++ b/t/Koha/Config.t >@@ -52,10 +52,8 @@ subtest 'read_from_file() tests' => sub { > > $parsing_result = 'error'; > >- warning_is >- {$result = Koha::Config->read_from_file("SomeFile.xml")} >- 'Error reading file SomeFile.xml', >- 'File failing to read raises warning'; >+ $result = eval {Koha::Config->read_from_file("SomeFile.xml")}; >+ like( $@, qr{.*Error reading file.*}, 'File failing to read raises warning'); > is( $result, undef, 'Returns undef on error confition' ); > }; > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19760
:
69568
|
69571
|
70014
|
70116
|
70117
| 70135