Bugzilla – Attachment 71864 Details for
Bug 19990
opac/opac-discharge.pl has a FIXME that can be fixed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug-19960: FIXME $available is not needed
Bug-19960-FIXME-available-is-not-needed.patch (text/plain), 1.13 KB, created by
Maksim Sen
on 2018-02-16 21:32:41 UTC
(
hide
)
Description:
Bug-19960: FIXME $available is not needed
Filename:
MIME Type:
Creator:
Maksim Sen
Created:
2018-02-16 21:32:41 UTC
Size:
1.13 KB
patch
obsolete
>From f04251e6bd3c5be4e288cf00b524f7b5e617adcb Mon Sep 17 00:00:00 2001 >From: Jenny Way <jwayway@hotmail.com> >Date: Wed, 17 Jan 2018 04:00:54 +0000 >Subject: [PATCH] Bug-19960: FIXME $available is not needed > >Test plan: >1. Open opac-discharge.pl >2. Check that $available doesn't exist > >https://bugs.koha-community.org/show_bug.cgi?id=19990 >Signed-off-by: Maksim Sen <maksim@inlibro.com> >--- > opac/opac-discharge.pl | 7 ------- > 1 file changed, 7 deletions(-) > >diff --git a/opac/opac-discharge.pl b/opac/opac-discharge.pl >index 7653dc6..1249534 100755 >--- a/opac/opac-discharge.pl >+++ b/opac/opac-discharge.pl >@@ -96,14 +96,7 @@ else { > borrowernumber => $loggedinuser, > pending => 1, > }); >- # FIXME looks like $available is not needed >- # If a user is discharged they have a validated discharge available >- my $available = Koha::Patron::Discharge::count({ >- borrowernumber => $loggedinuser, >- validated => 1, >- }); > $template->param( >- available => $available && Koha::Patron::Discharge::is_discharged({borrowernumber => $loggedinuser}), > pending => $pending, > ); > } >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19990
:
70599
| 71864 |
76554