Bugzilla – Attachment 72504 Details for
Bug 19908
Password should not be mandatory
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19908: Do not use .optional in password match validation function
Bug-19908-Do-not-use-optional-in-password-match-va.patch (text/plain), 1.49 KB, created by
Josef Moravec
on 2018-03-07 15:42:51 UTC
(
hide
)
Description:
Bug 19908: Do not use .optional in password match validation function
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-03-07 15:42:51 UTC
Size:
1.49 KB
patch
obsolete
>From 563768f6ebfa29582d7227ea1c4a530f2a96b000 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Mon, 5 Feb 2018 08:25:03 +0000 >Subject: [PATCH] Bug 19908: Do not use .optional in password match validation > function > >Test plan: >0) Aplly only first patch >1) You will be able to submit a from on member-password.pl even if the >passwords don't match >2) Apply this patch -> you can't be able to submit the form if the >paswords don't match, but you'll be able to submit the form when >password fields are blank > >Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/password_check.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/password_check.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/password_check.inc >index eb730e6..346929e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/password_check.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/password_check.inc >@@ -19,7 +19,7 @@ > }, _("Password contains leading and/or trailing spaces")); > jQuery.validator.addMethod("password_match", function(value, element){ > var new_password_node = $("input[name='" + new_password_node_name + "']:first"); >- return this.optional(element) || value == $(new_password_node).val(); >+ return value == $(new_password_node).val(); > }, _("Please enter the same password as above")); > </script> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19908
:
70242
|
71217
|
71970
|
71971
|
72159
|
72188
|
72189
|
72190
|
72503
| 72504