Bugzilla – Attachment 73039 Details for
Bug 17674
Allow UI to delete serials issues in batch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17674 - Adapting Serials.t to the namespace change
Bug-17674---Adapting-Serialst-to-the-namespace-cha.patch (text/plain), 4.67 KB, created by
Séverine Queune
on 2018-03-16 13:02:55 UTC
(
hide
)
Description:
Bug 17674 - Adapting Serials.t to the namespace change
Filename:
MIME Type:
Creator:
Séverine Queune
Created:
2018-03-16 13:02:55 UTC
Size:
4.67 KB
patch
obsolete
>From 7f95ad7c2a2e71da6721517975ca537bd353ae45 Mon Sep 17 00:00:00 2001 >From: Charles Farmer <charles.farmer@inLibro.com> >Date: Fri, 16 Feb 2018 16:53:28 -0500 >Subject: [PATCH] Bug 17674 - Adapting Serials.t to the namespace change >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >--- > t/db_dependent/Serials.t | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > >diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t >index d5f4996..1192cd1 100755 >--- a/t/db_dependent/Serials.t >+++ b/t/db_dependent/Serials.t >@@ -18,7 +18,7 @@ use Koha::DateUtils; > use Koha::Acquisition::Booksellers; > use Koha::Serials; > use t::lib::Mocks; >-use Test::More tests => 50; >+use Test::More tests => 49; > use t::lib::TestBuilder; > > BEGIN { >@@ -354,29 +354,30 @@ subtest "Do not generate an expected if one already exists" => sub { > > subtest "Test GetSerialItemsInformations " => sub { > plan tests => 4; >- is (C4::Serials::GetSerialItemsInformations(),0,"test GetSerialItemsInformation with nothing parameters "); >+ is (Koha::Serials::GetSerialItemsInformations(),0,"test GetSerialItemsInformation with nothing parameters "); > my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode }; > my $itemtype = $builder->build({ source => 'Itemtype' })->{ itemtype }; >+ my ($biblionumber1, $bibitemnumber) = AddBiblio(MARC::Record->new, ''); > my %item_infos = ( > homebranch => $branchcode, > holdingbranch => $branchcode, >- itype => $itemtype >+ itype => $itemtype, >+ biblioitemnumber => $bibitemnumber, > ); >- my $biblionumber1 = AddBiblio(MARC::Record->new, ''); > my $itemnumber1 = AddItem({ barcode => '0101', %item_infos }, $biblionumber1); > my $itemnumber2 = AddItem({ barcode => '0102', %item_infos }, $biblionumber1); > my $itemnumber3 = AddItem({ barcode => '0103', %item_infos }, $biblionumber1); > my $itemnumber4 = AddItem({ barcode => '0104', %item_infos }, $biblionumber1); > my @serialid = ($serials[0]->{serialid},$serials[1]->{serialid}); >- is (C4::Serials::GetSerialItemsInformations(@serialid),0,"test GetSerialItemsInformation with array of serialid and none have items"); >+ is (Koha::Serials::GetSerialItemsInformations(@serialid),0,"test GetSerialItemsInformation with array of serialid and none have items"); > subtest "Test with 2 serials and each have one item" => sub { > plan tests => 5; > AddItem2Serial($serialid[0],$itemnumber1); >- my @result = C4::Serials::GetSerialItemsInformations(@serialid); >+ my @result = Koha::Serials::GetSerialItemsInformations(@serialid); > is (scalar @result, 1 , "GetSerialItemsInformation return right length of array using 1 serial with 1 item"); > is ($result[0]->{countitems}, 1 , "GetSerialItemsInformation return right number items of serial1"); > AddItem2Serial($serialid[1],$itemnumber3); >- @result = C4::Serials::GetSerialItemsInformations(@serialid); >+ @result = Koha::Serials::GetSerialItemsInformations(@serialid); > is (scalar @result, 2 , "GetSerialItemsInformation return right length of array using 2 serials and each have 1 item"); > is ($result[0]->{countitems}, 1 , "GetSerialItemsInformation return right number items of serial1"); > is ($result[1]->{countitems}, 1 , "GetSerialItemsInformation return right number items of serial2"); >@@ -384,12 +385,12 @@ subtest "Test GetSerialItemsInformations " => sub { > subtest "Test with 2 serials and each have 2 items" => sub { > plan tests => 6; > AddItem2Serial($serialid[0],$itemnumber2); >- my @result = C4::Serials::GetSerialItemsInformations(@serialid); >+ my @result = Koha::Serials::GetSerialItemsInformations(@serialid); > is (scalar @result, 2 , "GetSerialItemsInformation return right length of array using 2 serials "); > is ($result[0]->{countitems}, 2 , "GetSerialItemsInformation return right number items of serial1"); > is ($result[1]->{countitems}, 1 , "GetSerialItemsInformation return right number items of serial2"); > AddItem2Serial($serialid[1],$itemnumber4); >- @result = C4::Serials::GetSerialItemsInformations(@serialid); >+ @result = Koha::Serials::GetSerialItemsInformations(@serialid); > is (scalar @result, 2 , "GetSerialItemsInformation return right length of array using 2 serials and each have 2 items "); > is ($result[0]->{countitems}, 2 , "GetSerialItemsInformation return right number items of serial1"); > is ($result[1]->{countitems}, 2 , "GetSerialItemsInformation return right number items of serial2"); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17674
:
57731
|
58262
|
58263
|
58264
|
60925
|
61314
|
61315
|
61316
|
66565
|
69007
|
69010
|
69011
|
69013
|
69976
|
69977
|
69978
|
69979
|
71865
|
71866
|
71867
|
71868
|
71869
|
72985
|
73032
|
73035
|
73036
|
73037
|
73038
|
73039
|
73040
|
74318
|
74359
|
74472
|
75643
|
75644
|
75645
|
75646
|
75647
|
75648
|
75649
|
77745
|
77746
|
77747
|
77748
|
77749
|
77750
|
77751
|
77861
|
77862
|
77863
|
77864
|
77865
|
77866
|
77867
|
77868
|
79415
|
79420
|
79421
|
79422
|
79423
|
79424
|
79425
|
79426
|
79427
|
79428
|
79453
|
79454
|
79455
|
79456
|
79457
|
79458
|
79459
|
79460
|
80859
|
80944
|
80955
|
82237
|
86689
|
95474
|
99434
|
99944
|
99945
|
100906
|
100907