Bugzilla – Attachment 7418 Details for
Bug 5674
Staff client - placing holds - patron name sort not ignoring letter case
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed Off] Bug 5674: patron name sort ignoring case when placing holds.
Signed-Off-Bug-5674-patron-name-sort-ignoring-case.patch (text/plain), 1.28 KB, created by
Liz Rea
on 2012-02-02 05:12:25 UTC
(
hide
)
Description:
[Signed Off] Bug 5674: patron name sort ignoring case when placing holds.
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2012-02-02 05:12:25 UTC
Size:
1.28 KB
patch
obsolete
>From eb6aed82cf5cd103ec1d7e97885d2d8bef6dc451 Mon Sep 17 00:00:00 2001 >From: Garry Collum <gcollum@gmail.com> >Date: Wed, 1 Feb 2012 12:35:27 -0500 >Subject: [PATCH] [Signed Off] Bug 5674: patron name sort ignoring case when > placing holds. >Content-Type: text/plain; charset="utf-8" > >Fixes the patron name sorting when placing holds. > >Testing - See Bug 5674. >Create two patrons. One named SMITH, THOMAS and the other Smith, John. >Search for an item to place on request. Do a patron search for Smith. > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> >Confirm both the original bug and the fix, sorting is correct now. >Patch does not change status of tests - prove t t/db_dependent xt no different from master. >--- > reserve/request.pl | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 21183da..24557f4 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -192,9 +192,9 @@ if ($borrowerslist) { > > foreach my $borrower ( > sort { >- $a->{surname} >- . $a->{firstname} cmp $b->{surname} >- . $b->{firstname} >+ uc($a->{surname} >+ . $a->{firstname}) cmp uc($b->{surname} >+ . $b->{firstname}) > } @{$borrowerslist} > ) > { >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5674
:
7414
| 7418