Bugzilla – Attachment 74877 Details for
Bug 20304
Warnings in cataloguing scripts need to be removed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20304: (QA follow-up) Remove unwanted 'my'
Bug-20304-QA-follow-up-Remove-unwanted-my.patch (text/plain), 1.15 KB, created by
Julian Maurice
on 2018-04-26 11:52:41 UTC
(
hide
)
Description:
Bug 20304: (QA follow-up) Remove unwanted 'my'
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-04-26 11:52:41 UTC
Size:
1.15 KB
patch
obsolete
>From 46c1d0689870f5736fa381509b8163f2cf358073 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Thu, 26 Apr 2018 13:48:58 +0200 >Subject: [PATCH] Bug 20304: (QA follow-up) Remove unwanted 'my' > >'my' creates a new '$value' variable, and prevented the '$value' in >outer scope to be modified > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > cataloguing/additem.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index c5d0d43952..5cb0809991 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -156,7 +156,7 @@ sub generate_subfield_form { > my $CNsubfield2 = substr($pref_itemcallnumber, 4, 1); > my $temp2 = $temp->field($CNtag); > if ($temp2) { >- my $value = join ' ', $temp2->subfield($CNsubfield) || q{}, $temp2->subfield($CNsubfield2) || q{}; >+ $value = join ' ', $temp2->subfield($CNsubfield) || q{}, $temp2->subfield($CNsubfield2) || q{}; > #remove any trailing space incase one subfield is used > $value =~ s/^\s+|\s+$//g; > } >-- >2.14.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20304
:
72271
|
72272
|
73522
|
73869
|
73961
|
74876
| 74877