From b343b20acb752fe3b729cfb415df2200455ed056 Mon Sep 17 00:00:00 2001 From: Juan Romay Sieira Date: Thu, 9 Feb 2012 17:29:10 +0100 Subject: [PATCH] Bug 6138 - Show local help and isbd punctuation automatically when we are cataloguing Content-Type: text/plain; charset="utf-8" --- C4/Biblio.pm | 8 ++- admin/marc_subfields_structure.pl | 16 +++++- cataloguing/addbiblio.pl | 11 ++++ installer/data/mysql/kohastructure.sql | 2 + installer/data/mysql/updatedatabase.pl | 10 ++++ koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css | 5 ++ koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js | 58 +++++++++++++++++++- .../en/modules/admin/marc_subfields_structure.tt | 21 +++++--- .../prog/en/modules/cataloguing/addbiblio.tt | 8 +++ 9 files changed, 125 insertions(+), 14 deletions(-) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index 98e4f5b..128af2c 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -958,7 +958,7 @@ sub GetMarcStructure { } $sth = $dbh->prepare( - "SELECT tagfield,tagsubfield,liblibrarian,libopac,tab,mandatory,repeatable,authorised_value,authtypecode,value_builder,kohafield,seealso,hidden,isurl,link,defaultvalue + "SELECT tagfield,tagsubfield,liblibrarian,libopac,tab,mandatory,repeatable,authorised_value,authtypecode,value_builder,kohafield,seealso,hidden,isurl,link,defaultvalue,punctuation,help FROM marc_subfield_structure WHERE frameworkcode=? ORDER BY tagfield,tagsubfield @@ -977,10 +977,12 @@ sub GetMarcStructure { my $isurl; my $link; my $defaultvalue; + my $punctuation; + my $help; while ( ( $tag, $subfield, $liblibrarian, $libopac, $tab, $mandatory, $repeatable, $authorised_value, - $authtypecode, $value_builder, $kohafield, $seealso, $hidden, $isurl, $link, $defaultvalue + $authtypecode, $value_builder, $kohafield, $seealso, $hidden, $isurl, $link, $defaultvalue, $punctuation, $help ) = $sth->fetchrow ) { @@ -997,6 +999,8 @@ sub GetMarcStructure { $res->{$tag}->{$subfield}->{isurl} = $isurl; $res->{$tag}->{$subfield}->{'link'} = $link; $res->{$tag}->{$subfield}->{defaultvalue} = $defaultvalue; + $res->{$tag}->{$subfield}->{punctuation} = $punctuation; + $res->{$tag}->{$subfield}->{help} = $help; } $marc_structure_cache->{$forlibrarian}->{$frameworkcode} = $res; diff --git a/admin/marc_subfields_structure.pl b/admin/marc_subfields_structure.pl index 2c69733..b7e2b17 100755 --- a/admin/marc_subfields_structure.pl +++ b/admin/marc_subfields_structure.pl @@ -179,6 +179,8 @@ if ( $op eq 'add_form' ) { while ( $data = $sth->fetchrow_hashref ) { my %row_data; # get a fresh hash for the row data $row_data{defaultvalue} = $data->{defaultvalue}; + $row_data{punctuation} = $data->{'punctuation'}; + $row_data{help} = CGI::escapeHTML( $data->{'help'} ); $row_data{tab} = CGI::scrolling_list( -name => 'tab', -id => "tab$i", @@ -386,11 +388,11 @@ elsif ( $op eq 'add_validate' ) { # values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)" # ); my $sth_insert = $dbh->prepare(qq{ - insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,authtypecode,value_builder,hidden,isurl,frameworkcode, link,defaultvalue) - values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?) + insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian,libopac,repeatable,mandatory,kohafield,tab,seealso,authorised_value,authtypecode,value_builder,hidden,isurl,frameworkcode, link,defaultvalue,punctuation,help) + values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?) }); my $sth_update = $dbh->prepare(qq{ - update marc_subfield_structure set tagfield=?, tagsubfield=?, liblibrarian=?, libopac=?, repeatable=?, mandatory=?, kohafield=?, tab=?, seealso=?, authorised_value=?, authtypecode=?, value_builder=?, hidden=?, isurl=?, frameworkcode=?, link=?, defaultvalue=? + update marc_subfield_structure set tagfield=?, tagsubfield=?, liblibrarian=?, libopac=?, repeatable=?, mandatory=?, kohafield=?, tab=?, seealso=?, authorised_value=?, authtypecode=?, value_builder=?, hidden=?, isurl=?, frameworkcode=?, link=?, defaultvalue=?, punctuation=?, help=? where tagfield=? and tagsubfield=? and frameworkcode=? }); my @tagsubfield = $input->param('tagsubfield'); @@ -405,6 +407,8 @@ elsif ( $op eq 'add_validate' ) { my @value_builder = $input->param('value_builder'); my @link = $input->param('link'); my @defaultvalue = $input->param('defaultvalue'); + my @punctuation = $input->param('punctuation'); + my @help = $input->param('help'); for ( my $i = 0 ; $i <= $#tagsubfield ; $i++ ) { my $tagfield = $input->param('tagfield'); @@ -425,6 +429,8 @@ elsif ( $op eq 'add_validate' ) { my $isurl = $input->param("isurl$i") ? 1 : 0; my $link = $link[$i]; my $defaultvalue = $defaultvalue[$i]; + my $punctuation = $punctuation[$i]; + my $help = $help[$i]; if (defined($liblibrarian) && $liblibrarian ne "") { unless ( C4::Context->config('demo') eq 1 ) { @@ -447,6 +453,8 @@ elsif ( $op eq 'add_validate' ) { $frameworkcode, $link, $defaultvalue, + $punctuation, + $help, ( $tagfield, $tagsubfield, @@ -472,6 +480,8 @@ elsif ( $op eq 'add_validate' ) { $frameworkcode, $link, $defaultvalue, + $punctuation, + $help, ); } } diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl index f29e410..0bfcc27 100755 --- a/cataloguing/addbiblio.pl +++ b/cataloguing/addbiblio.pl @@ -332,6 +332,8 @@ sub create_input { mandatory => $tagslib->{$tag}->{$subfield}->{mandatory}, repeatable => $tagslib->{$tag}->{$subfield}->{repeatable}, kohafield => $tagslib->{$tag}->{$subfield}->{kohafield}, + punctuation => $tagslib->{$tag}->{$subfield}->{punctuation}, + help => $tagslib->{$tag}->{$subfield}->{help}, index => $index_tag, id => "tag_".$tag."_subfield_".$id_subfield."_".$index_tag."_".$index_subfield, value => $value, @@ -496,11 +498,20 @@ sub create_input { name=\"".$subfield_data{id}."\" value=\"$value\" tabindex=\"1\" + punctuation=\"".$subfield_data{punctuation}."\" size=\"67\" maxlength=\"$max_length\" class=\"input_marceditor\" + onfocus=\"javascript:GetPunctuation(this);\" + onblur=\"javascript:CheckPunctuation(this);\" \/> "; + if ($subfield_data{help}){ + $subfield_data{marc_value} .= " +  Show help +
 " . $subfield_data{help} . "
+ "; + } } } $subfield_data{'index_subfield'} = $index_subfield; diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql index 37113c2..70ae5ff 100644 --- a/installer/data/mysql/kohastructure.sql +++ b/installer/data/mysql/kohastructure.sql @@ -1197,6 +1197,8 @@ CREATE TABLE `marc_subfield_structure` ( `seealso` varchar(1100) default NULL, `link` varchar(80) default NULL, `defaultvalue` text default NULL, + `punctuation` varchar(5) default NULL, + `help` varchar(255) default NULL, PRIMARY KEY (`frameworkcode`,`tagfield`,`tagsubfield`), KEY `kohafield_2` (`kohafield`), KEY `tab` (`frameworkcode`,`tab`), diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl index 099dfb9..fa79141 100755 --- a/installer/data/mysql/updatedatabase.pl +++ b/installer/data/mysql/updatedatabase.pl @@ -4663,6 +4663,16 @@ ENDOFRENEWAL print "Upgrade to $DBversion done (Added a system preference to allow renewal of Patron account either from todays date or from existing expiry date in the patrons account.)\n"; SetVersion($DBversion); } + +$DBversion = "3.07.00.XXX"; +if (C4::Context->preference("Version") < TransformToNum($DBversion)) { + $dbh->do(" + ALTER TABLE `marc_subfield_structure` ADD `punctuation` VARCHAR( 5 ) NULL , ADD `help` VARCHAR( 255 ) NULL; + "); + print "Upgrade to $DBversion done (Punctuation and cataloguing help)\n"; + SetVersion($DBversion); +} + =head1 FUNCTIONS =head2 DropAllForeignKeys($table) diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css index d2489b3..a1c0860 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css +++ b/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css @@ -83,6 +83,11 @@ a.tagnum { text-decoration : none; } +.divsubfieldhelp { + background-color: #F0FFEF; + border: #EFEFEF 1px solid; +} + .subfield { color : #00698a; float: left; diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js index f491773..a21ec68 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js @@ -92,4 +92,60 @@ function checkEnter(e){ //e is event object passed from function invocation function clearHoldFor(){ $.cookie("holdfor",null, { path: "/", expires: 0 }); -} \ No newline at end of file +} + + +/* + * Place punctuation when cataloguing + */ + +function trim(s) { + while (s.length>0 && (s[0]==' '||s[0]=='\n')) s=s.substring(1, s.length); + while (s.length>0 && (s[s.length-1]==' '||s[s.length-1]=='\n')) s=s.substring(0, s.length-1); + while (s.search (" ") != -1){ + s = s.replace (" ",""); + } + return s; +} + +/* + Place the cursor in a determinate place into a textbox +*/ + +function placePositionTextbox(elem, myPos) { + + if(elem != null) { + if(elem.createTextRange) { + var range = elem.createTextRange(); + range.move('character', myPos); + range.select(); + } + else { + if(elem.selectionStart) { + elem.focus(); + elem.setSelectionRange(myPos, myPos); + } + else + elem.focus(); + } + } +} + +function GetPunctuation(field){ + var val = field.value; + if (trim(val) == ""){ + field.value = field.getAttribute('punctuation'); + placePositionTextbox(field,field.value.length); + } +} + +function CheckPunctuation(field){ + var val = field.value; + if (val == field.getAttribute('punctuation')){ + field.value = ""; + } +} + +/* + * END - Place punctuation when cataloguing + */ \ No newline at end of file diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt index 18c1db3..69d52c3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt @@ -106,14 +106,19 @@