Bugzilla – Attachment 75505 Details for
Bug 20778
Unable to delete a subscription
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20778: Fix subscription deletion. Also remove the first confirmation pop because we have another one.
Bug-20778-Fix-subscription-deletion-Also-remove-th.patch (text/plain), 1.55 KB, created by
Biblibre Sandboxes
on 2018-05-23 14:45:49 UTC
(
hide
)
Description:
Bug 20778: Fix subscription deletion. Also remove the first confirmation pop because we have another one.
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2018-05-23 14:45:49 UTC
Size:
1.55 KB
patch
obsolete
>From 5eb5468ccc09d2f7138a564e68829b6f5c61c4c0 Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Fri, 18 May 2018 12:45:34 +0000 >Subject: [PATCH] Bug 20778: Fix subscription deletion. Also remove the first > confirmation pop because we have another one. >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan: > - go to a subscription detail page, > - click on edit -> delete subscription, > - confirm deletion, > - check that the subscription is no longer here > >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >--- > koha-tmpl/intranet-tmpl/prog/js/serials-toolbar.js | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/serials-toolbar.js b/koha-tmpl/intranet-tmpl/prog/js/serials-toolbar.js >index 8ef2db9..043af0f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/serials-toolbar.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/serials-toolbar.js >@@ -14,10 +14,7 @@ function confirm_reopen() { > } > > function confirm_deletion() { >- var is_confirmed = confirm( CONFIRM_DELETE_SUBSCRIPTION ); >- if (is_confirmed) { >- window.location="subscription-detail.pl?subscriptionid=[% subscriptionid %]&op=del"; >- } >+ window.location="subscription-detail.pl?subscriptionid=" + subscriptionid + "&op=del"; > } > function popup(subscriptionid) { > newin=window.open("subscription-renew.pl?mode=popup&subscriptionid="+subscriptionid,'popup','width=590,height=440,toolbar=false,scrollbars=yes'); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20778
:
75429
|
75505
|
75777
|
75778
|
75793