Bugzilla – Attachment 76311 Details for
Bug 14222
Sort holds in OPAC by priority
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14222: Sort holds in OPAC by priority
Bug-14222-Sort-holds-in-OPAC-by-priority.patch (text/plain), 3.26 KB, created by
Maryse Simard
on 2018-06-22 21:23:40 UTC
(
hide
)
Description:
Bug 14222: Sort holds in OPAC by priority
Filename:
MIME Type:
Creator:
Maryse Simard
Created:
2018-06-22 21:23:40 UTC
Size:
3.26 KB
patch
obsolete
>From 0baa23037e9cac8f593788833c14963611a72a56 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 21 Jun 2018 14:32:52 +0000 >Subject: [PATCH] Bug 14222: Sort holds in OPAC by priority > >This patch modifies the markup of the users's holds table in the OPAC so >that if hold priority is displayed, the table will be sorted by that >number. > >To test, apply the patch and set the OPACShowHoldQueueDetails system >preference to "Show priority level" or "Show holds and their priority >level." > > - Log in to the OPAC as a user who has multiple holds with various > priorities. Include priorities which could be sorted incorrectly > using a text sort, e.g. 1, 10. > - View the holds tab on the "your summary" page. Confirm that the > priority column is sorted by default with the lowest priority holds > first. > - Set the OPACShowHoldQueueDetails preference to "Show holds" and > confirm that the holds table still displays correctly, sorted by > "Placed on" ascending. > >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> >Followed the test plan and the patch works. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 85680af..cb49a08 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -577,11 +577,15 @@ > <thead> > <tr> > <th class="anti-the">Title</th> >- <th class="psort title-string">Placed on</th> >+ [% IF ( showpriority ) %] >+ <th class="title-string">Placed on</th> >+ [% ELSE %] >+ <th class="psort title-string">Placed on</th> >+ [% END %] > <th class="title-string">Expires on</th> > <th>Pick up location</th> > [% IF ( showpriority ) %] >- <th>Priority</th> >+ <th class="psort">Priority</th> > [% END %] > <th>Status</th> > [% IF SuspendHoldsOpac %] >@@ -643,7 +647,7 @@ > [% RESERVE.branch.branchname %] > </td> > [% IF ( showpriority ) %] >- <td class="priority"> >+ <td data-order="[% RESERVE.priority %]" class="priority"> > <span class="tdlabel">Priority:</span> > [% RESERVE.priority %] > </td> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14222
:
76237
|
76311
|
76408