From 89696937559b630d091ab2011e20eac80d9e524b Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Thu, 28 Jun 2018 23:00:02 +0000 Subject: [PATCH] Bug 19990: Removing unnecessary variable from opac/opac-discharge.pl To test: 1) Ensure useDischarge syspref is enabled 2) Go to OPAC, click ask for a discharge 3) Go to staff side homepage, click 'Discharge requests pending' 4) Allow Discharge 5) Go to the user's page and remove the discharge restriction 6) Apply patch and repeat steps 2-4, ensuring that all behaviour stays the same Sponsored-by: Catalyst IT --- opac/opac-discharge.pl | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/opac/opac-discharge.pl b/opac/opac-discharge.pl index 7653dc6..b82e46a 100755 --- a/opac/opac-discharge.pl +++ b/opac/opac-discharge.pl @@ -96,14 +96,8 @@ else { borrowernumber => $loggedinuser, pending => 1, }); - # FIXME looks like $available is not needed - # If a user is discharged they have a validated discharge available - my $available = Koha::Patron::Discharge::count({ - borrowernumber => $loggedinuser, - validated => 1, - }); $template->param( - available => $available && Koha::Patron::Discharge::is_discharged({borrowernumber => $loggedinuser}), + available => $pending && Koha::Patron::Discharge::is_discharged({borrowernumber => $loggedinuser}), pending => $pending, ); } -- 2.1.4