Bugzilla – Attachment 77954 Details for
Bug 20739
Update two-column templates with Bootstrap grid: Administration part 3
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3
Bug-20739-Update-two-column-templates-with-Bootstr.patch (text/plain), 11.10 KB, created by
Jonathan Druart
on 2018-08-16 19:40:16 UTC
(
hide
)
Description:
Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-08-16 19:40:16 UTC
Size:
11.10 KB
patch
obsolete
>From baee7f80dba0e2c2195fda973baad978964784f1 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 1 May 2018 18:46:33 +0000 >Subject: [PATCH] Bug 20739: Update two-column templates with Bootstrap grid, > Administration part 3 > >This patch modifies several acquisitions templates to use the Bootstrap >grid instead of YUI. > >This patch also removes obsolete "text/javascript" attributes from ><script> tags in the modified templates. > >To test, apply the patch and view the following pages, confirming that >they look correct at various browser widths: > > - Administration -> Columns settings > - Administration -> Patron categories > - View and edit patron categories > - Administration -> Cities and towns > - View and edit cities > - Administration -> Classification sources > - View and edit classification sources > - Administration -> MARC bibliographic framework test > >I'm not sure if this standalone interface is actually in use, but you >can navigate directly to /cgi-bin/koha/admin/clone-rules.pl to see a >form which is usually submitted from the circulation and fines rules >interface. View the page to confirm it looks correct. > >Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../prog/en/modules/admin/categories.tt | 25 ++++++++------ > .../prog/en/modules/admin/checkmarc.tt | 24 ++++++------- > .../intranet-tmpl/prog/en/modules/admin/cities.tt | 40 ++++++++++++---------- > .../prog/en/modules/admin/classsources.tt | 23 +++++++------ > .../prog/en/modules/admin/clone-rules.tt | 22 ++++++------ > .../prog/en/modules/admin/columns_settings.tt | 25 ++++++++------ > 6 files changed, 87 insertions(+), 72 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >index 6c4aa549d3..585a47aef5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >@@ -22,10 +22,10 @@ > [% IF op == 'delete_confirmed' %] <a href="/cgi-bin/koha/admin/categories.pl">Patron categories</a> › Category deleted[% END %] > [% IF op == 'list' %]Patron categories[% END %]</div> > >-<div id="doc3" class="yui-t2"> >- <div id="bd"> >- <div id="yui-main"> >- <div class="yui-b"> >+<div class="main container-fluid"> >+ <div class="row"> >+ <div class="col-sm-10 col-sm-push-2"> >+ <main> > > [% FOR m IN messages %] > <div class="dialog [% m.type | html %]"> >@@ -485,19 +485,22 @@ > [% END %] > [% END %] > >-</div> >-</div> >-<div class="yui-b"> >-[% INCLUDE 'admin-menu.inc' %] >-</div> >-</div> >+ </main> >+ </div> <!-- /.col-sm-10.col-sm-push-2 --> >+ >+ <div class="col-sm-2 col-sm-pull-10"> >+ <aside> >+ [% INCLUDE 'admin-menu.inc' %] >+ </aside> >+ </div> <!-- /.col-sm-2.col-sm-pull-10 --> >+ </div> <!-- /.row --> > > [% MACRO jsinclude BLOCK %] > [% Asset.js("js/admin-menu.js") | $raw %] > [% Asset.js("js/messaging-preference-form.js") | $raw %] > [% INCLUDE 'calendar.inc' %] > [% INCLUDE 'datatables.inc' %] >- <script type="text/javascript"> >+ <script> > var MSG_CATEGORYCODE_CHARS = _("Category code can only contain the following characters: letters, numbers, - and _."); > var MSG_ONE_ENROLLMENTPERIOD = ("Please choose an enrollment period in months OR by date."); > </script> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/checkmarc.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/checkmarc.tt >index 6b95db3d09..c940616bd5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/checkmarc.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/checkmarc.tt >@@ -13,11 +13,10 @@ > <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › MARC check > [% IF ( total ) %]: [% total | html %] errors found[% ELSE %] : Configuration OK![% END %]</div> > >-<div id="doc3" class="yui-t2"> >- >- <div id="bd"> >- <div id="yui-main"> >- <div class="yui-b"> >+<div class="main container-fluid"> >+ <div class="row"> >+ <div class="col-sm-10 col-sm-push-2"> >+ <main> > > <h1>MARC bibliographic framework test</h1> > <table> >@@ -271,14 +270,15 @@ > <p><b>Configuration OK, you don't have errors in your MARC parameters table</b></p> > [% END %] > >+ </main> >+ </div> <!-- /.col-sm-10.col-sm-push-2 --> > >- >-</div> >-</div> >-<div class="yui-b"> >-[% INCLUDE 'admin-menu.inc' %] >-</div> >-</div> >+ <div class="col-sm-2 col-sm-pull-10"> >+ <aside> >+ [% INCLUDE 'admin-menu.inc' %] >+ </aside> >+ </div> <!-- /.col-sm-2.col-sm-pull-10 --> >+ </div> <!-- /.row --> > > [% MACRO jsinclude BLOCK %] > [% Asset.js("js/admin-menu.js") | $raw %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >index f41a6cd4ff..40cef20b64 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >@@ -22,11 +22,10 @@ > [% END %] > </div> > >-<div id="doc3" class="yui-t2"> >- >- <div id="bd"> >- <div id="yui-main"> >- <div class="yui-b"> >+<div class="main container-fluid"> >+ <div class="row"> >+ <div class="col-sm-10 col-sm-push-2"> >+ <main> > > [% FOR m IN messages %] > <div class="dialog [% m.type | html %]"> >@@ -138,12 +137,14 @@ > [% IF cities.count %] > <table id="table_cities"> > <thead> >- <th>City ID</th> >- <th>City</th> >- <th>State</th> >- <th>ZIP/Postal code</th> >- <th>Country</th> >- <th>Actions</th> >+ <tr> >+ <th>City ID</th> >+ <th>City</th> >+ <th>State</th> >+ <th>ZIP/Postal code</th> >+ <th>Country</th> >+ <th>Actions</th> >+ </tr> > </thead> > <tbody> > [% FOREACH city IN cities %] >@@ -168,17 +169,20 @@ > [% END %] > [% END %] > >-</div> >-</div> >-<div class="yui-b"> >-[% INCLUDE 'admin-menu.inc' %] >-</div> >-</div> >+ </main> >+ </div> <!-- /.col-sm-10.col-sm-push-2 --> >+ >+ <div class="col-sm-2 col-sm-pull-10"> >+ <aside> >+ [% INCLUDE 'admin-menu.inc' %] >+ </aside> >+ </div> <!-- /.col-sm-2.col-sm-pull-10 --> >+ </div> <!-- /.row --> > > [% MACRO jsinclude BLOCK %] > [% Asset.js("js/admin-menu.js") | $raw %] > [% INCLUDE 'datatables.inc' %] >- <script type="text/javascript"> >+ <script> > $(document).ready(function() { > $("#table_cities").dataTable($.extend(true, {}, dataTablesDefaults, { > "aoColumnDefs": [ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >index a00e59442b..5882915cde 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >@@ -45,10 +45,10 @@ > [% END %] > </div> > >-<div id="doc3" class="yui-t2"> >- <div id="bd"> >- <div id="yui-main"> >- <div class="yui-b"> >+<div class="main container-fluid"> >+ <div class="row"> >+ <div class="col-sm-10 col-sm-push-2"> >+ <main> > > [% IF ( class_source_form ) %] > [% IF ( edit_class_source ) %] >@@ -262,12 +262,15 @@ > > [% END %] > >- </div> >- </div> >-<div class="yui-b"> >-[% INCLUDE 'admin-menu.inc' %] >- </div> >-</div> >+ </main> >+ </div> <!-- /.col-sm-10.col-sm-push-2 --> >+ >+ <div class="col-sm-2 col-sm-pull-10"> >+ <aside> >+ [% INCLUDE 'admin-menu.inc' %] >+ </aside> >+ </div> <!-- /.col-sm-2.col-sm-pull-10 --> >+ </div> <!-- /.row --> > > [% MACRO jsinclude BLOCK %] > [% Asset.js("js/admin-menu.js") | $raw %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/clone-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/clone-rules.tt >index 08fd070b0e..d7ff05068d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/clone-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/clone-rules.tt >@@ -12,11 +12,11 @@ > > <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › <a href="/cgi-bin/koha/admin/smart-rules.pl">Circulation and fine rules</a> › Clone circulation and fine rules</div> > >-<div id="doc3" class="yui-t1"> >+<div class="main container-fluid"> >+ <div class="row"> >+ <div class="col-sm-10 col-sm-push-2"> >+ <main> > >-<div id="bd"> >- <div id="yui-main"> >- <div class="yui-b"> > <h2>Cloning circulation and fine rules > [% IF frombranch %] from "[% Branches.GetName( frombranch ) | html %]"[% END %] > [% IF tobranch %] to "[% Branches.GetName( tobranch ) | html %]"[% END %] >@@ -60,13 +60,15 @@ > </form> > > [% END %] >- </div> >+ </main> >+ </div> <!-- /.col-sm-10.col-sm-push-2 --> > >-</div> >-<div class="yui-b"> >-[% INCLUDE 'admin-menu.inc' %] >-</div> >-</div> >+ <div class="col-sm-2 col-sm-pull-10"> >+ <aside> >+ [% INCLUDE 'admin-menu.inc' %] >+ </aside> >+ </div> <!-- /.col-sm-2.col-sm-pull-10 --> >+ </div> <!-- /.row --> > > [% MACRO jsinclude BLOCK %] > [% Asset.js("js/admin-menu.js") | $raw %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >index a5624c6e9d..b41b653533 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >@@ -97,10 +97,11 @@ > [% INCLUDE 'prefs-admin-search.inc' %] > <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › Columns settings</div> > >-<div id="doc3" class="yui-t2"> >- <div id="bd"> >- <div id="yui-main"> >- <div class="yui-b"> >+<div class="main container-fluid"> >+ <div class="row"> >+ <div class="col-sm-10 col-sm-push-2"> >+ <main> >+ > <h2>Columns settings</h2> > <div id="modules"> > <h3><a href="#acqui">Acquisition</a></h3> >@@ -158,17 +159,19 @@ > </div> > > </div> >- </div> >- </div> >+ </main> >+ </div> <!-- /.col-sm-10.col-sm-push-2 --> > >- <div class="yui-b"> >- [% INCLUDE 'admin-menu.inc' %] >- </div> >- </div> >+ <div class="col-sm-2 col-sm-pull-10"> >+ <aside> >+ [% INCLUDE 'admin-menu.inc' %] >+ </aside> >+ </div> <!-- /.col-sm-2.col-sm-pull-10 --> >+ </div> <!-- /.row --> > > [% MACRO jsinclude BLOCK %] > [% Asset.js("js/admin-menu.js") | $raw %] >- <script type="text/javascript"> >+ <script> > $(document).ready( function() { > var accordion = $( "#modules" ).accordion({ > collapsible: true, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20739
:
77016
|
77879
| 77954