Bugzilla – Attachment 80741 Details for
Bug 21005
Missing row/column defaults cause unexpected results in report wizards
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21005: Address QA tool failures on tabs
Bug-21005-Address-QA-tool-failures-on-tabs.patch (text/plain), 4.36 KB, created by
Jonathan Druart
on 2018-10-17 16:39:50 UTC
(
hide
)
Description:
Bug 21005: Address QA tool failures on tabs
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-17 16:39:50 UTC
Size:
4.36 KB
patch
obsolete
>From bb13bd7674cdc7dd757fb70f0bfe0bd77b5c1aff Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 17 Oct 2018 01:39:41 +0000 >Subject: [PATCH] Bug 21005: Address QA tool failures on tabs > >Only whitespace changes. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >index e6986fa628..25c4843e4d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >@@ -77,7 +77,7 @@ > <tr> > <td>Patron category</td> > <td><input type="radio" name="Line" value="categorycode" /></td> >- <td><input type="radio" checked="checked" name="Column" value="categorycode" /></td> >+ <td><input type="radio" checked="checked" name="Column" value="categorycode" /></td> > <td> > <select name="Filter" size="1" id="catcode"> > <option value=""></option> >@@ -137,7 +137,7 @@ > > <tr> > <td>Library</td> >- <td><input type="radio" checked="checked" name="Line" value="branchcode" /></td> >+ <td><input type="radio" checked="checked" name="Line" value="branchcode" /></td> > <td><input type="radio" name="Column" value="branchcode" /></td> > <td> > <select name="Filter" size="1" id="branch"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >index 692b05ceaa..c741b54f8b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >@@ -99,7 +99,7 @@ > <tr> > <td>Item type</td> > <td><input type="radio" name="Line" value="[% item_itype | html %]" /></td> >- <td><input type="radio" checked="checked" name="Column" value="[% item_itype | html %]" /></td> >+ <td><input type="radio" checked="checked" name="Column" value="[% item_itype | html %]" /></td> > <td><select name="Filter" id="[% item_itype | html %]"> > <option value=""> </option> > [% FOREACH itemtype IN itemtypes %] >@@ -122,7 +122,7 @@ > </tr> > <tr> > <td>Home library</td> >- <td><input type="radio" checked="checked" name="Line" value="items.homebranch" /></td> >+ <td><input type="radio" checked="checked" name="Line" value="items.homebranch" /></td> > <td><input type="radio" name="Column" value="items.homebranch" /></td> > <td><select name="Filter" id="branch"> > <option value=""> </option> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt >index 09d3966629..6a61633de9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt >@@ -77,7 +77,7 @@ > <tr class="hilighted"> > <td>Checkout date</td> > <td><input type="radio" name="Line" value="timestamp" /></td> >- <td><input type="radio" checked="checked" name="Column" value="timestamp" /></td> >+ <td><input type="radio" checked="checked" name="Column" value="timestamp" /></td> > <td > <label for="from">From</label> <input type="text" size="10" id="from" name="Filter" /> > <label for="to">To</label> <input size="10" id="to" name="Filter" value="" type="text" /> > <span class="hint">[% INCLUDE 'date-format.inc' %]</span> >@@ -118,7 +118,7 @@ > </tr> > <tr class="hilighted"> > <td>Patron category</td> >- <td><input type="radio" checked="checked" name="Line" value="borrowers.categorycode" /></td> >+ <td><input type="radio" checked="checked" name="Line" value="borrowers.categorycode" /></td> > <td><input type="radio" name="Column" value="borrowers.categorycode" /></td> > <td> > <select name="Filter" size="1" id="borcat"> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21005
:
77644
|
80686
|
80687
|
80740
| 80741