From 17ea2bc0927bd39b13065c7bb437093f39751f92 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 18 Oct 2018 10:05:38 +0000 Subject: [PATCH] Bug 21593: Remove GROUP BY from GetAuthValueDropbox With new MYSQL modes we are permitted only full group by. In this case I don't think we need a GROUP BY at all To test: 1 - Try to pay a fine or create a borrower 2 - Internal server error 3 - Apply patch 4 - Page should load 5 - Test various authorised values ot ensure they work e.g. Set bsort1 and bsort2 to have some authorised values with and without branch limits set PAYMENT_TYPE to have some values with and without branch limits Signed-off-by: Martin Renvoize --- Koha/Template/Plugin/AuthorisedValues.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/Koha/Template/Plugin/AuthorisedValues.pm b/Koha/Template/Plugin/AuthorisedValues.pm index 2692c15a06..95b0c4c939 100644 --- a/Koha/Template/Plugin/AuthorisedValues.pm +++ b/Koha/Template/Plugin/AuthorisedValues.pm @@ -48,7 +48,6 @@ sub GetAuthValueDropbox { category => $category, }, { - group_by => 'lib', order_by => [ 'category', 'lib', 'lib_opac' ], } ); -- 2.19.1