Bugzilla – Attachment 80843 Details for
Bug 21475
Error in the OPAC when viewing a record which has no biblio-level itemtype
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21475: Fix crash on missing default itemtype
Bug-21475-Fix-crash-on-missing-default-itemtype.patch (text/plain), 1.40 KB, created by
Julian Maurice
on 2018-10-18 13:52:35 UTC
(
hide
)
Description:
Bug 21475: Fix crash on missing default itemtype
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2018-10-18 13:52:35 UTC
Size:
1.40 KB
patch
obsolete
>From cd6befd6556efaf39a67e53a17c725222f338eec Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 15 Oct 2018 14:01:14 +0200 >Subject: [PATCH] Bug 21475: Fix crash on missing default itemtype > >Test plan: >Enable ArticleRequests. >Find book without itemtype (942c). Maybe you need this: > update biblioitems set itemtype=NULL where biblionumber=[...] >Goto opac detail for that book. No crash anymore? > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > opac/opac-detail.pl | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 6f10c6bde3..cc735ee152 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -758,9 +758,12 @@ my $subtitle = GetRecordValue('subtitle', $record, GetFrameworkCode($bib > > if( C4::Context->preference('ArticleRequests') ) { > my $patron = $borrowernumber ? Koha::Patrons->find($borrowernumber) : undef; >+ my $itemtype = Koha::ItemTypes->find($biblio->itemtype); > my $artreqpossible = $patron > ? $biblio->can_article_request( $patron ) >- : Koha::ItemTypes->find($biblio->itemtype)->may_article_request; >+ : $itemtype >+ ? $itemtype->may_article_request >+ : q{}; > $template->param( artreqpossible => $artreqpossible ); > } > >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21475
:
80591
|
80593
|
80595
| 80843