From d57e20bcac7decf6621eee818fe32f55d8053f6a Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 25 Oct 2018 10:24:46 -0300 Subject: [PATCH] Bug 21596: (follow-up) Handle updated_on Default value should only used if not exist. We got a failing test with the previous patch: # Failed test 'borrowers.updated_on should have been kept to what we set on creating' # at t/db_dependent/Patrons.t line 78. # got: '1' # expected: '0' Test plan: prove -r t/Auth_with_shibboleth.t t/db_dependent/Patrons.t t/db_dependent/Koha/Patron* --- Koha/Patron.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/Patron.pm b/Koha/Patron.pm index ec13bb0296..c3ea18ff06 100644 --- a/Koha/Patron.pm +++ b/Koha/Patron.pm @@ -200,7 +200,7 @@ sub store { if ( defined $self->updated_on and not $self->updated_on ) { $self->updated_on(undef); - } else { + } elsif ( not $self->updated_on ) { # This is bad we should use columns_info instead # But it will avoid unecessary processing $self->updated_on(\"current_timestamp"); -- 2.11.0