From 626c918b57a823f1122e569def516ab9729dd786 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 25 Oct 2018 14:25:10 +0200 Subject: [PATCH] Bug 21337: (QA follow-up) Rename exception code Content-Type: text/plain; charset=utf-8 Patron::Delete becomes Patron::FailedDelete. Trivial replace. Signed-off-by: Marcel de Rooy --- Koha/Exceptions/Patron.pm | 2 +- Koha/Patrons.pm | 2 +- t/db_dependent/Koha/Patrons.t | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Koha/Exceptions/Patron.pm b/Koha/Exceptions/Patron.pm index 754f004..8eac9c9 100644 --- a/Koha/Exceptions/Patron.pm +++ b/Koha/Exceptions/Patron.pm @@ -6,7 +6,7 @@ use Exception::Class ( 'Koha::Exceptions::Patron' => { description => "Something went wrong!" }, - 'Koha::Exceptions::Patron::Delete' => { + 'Koha::Exceptions::Patron::FailedDelete' => { description => "Deleting patron failed" }, ); diff --git a/Koha/Patrons.pm b/Koha/Patrons.pm index 21061cd..dedf4c4 100644 --- a/Koha/Patrons.pm +++ b/Koha/Patrons.pm @@ -229,7 +229,7 @@ sub delete { my ( $set, $params ) = @_; while( my $patron = $set->next ) { $patron->move_to_deleted if $params->{move}; - $patron->delete == 1 || Koha::Exceptions::Patron::Delete->throw; + $patron->delete == 1 || Koha::Exceptions::Patron::FailedDelete->throw; $patrons_deleted++; } }, $self, $params ); diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t index e2e8019..c552220 100644 --- a/t/db_dependent/Koha/Patrons.t +++ b/t/db_dependent/Koha/Patrons.t @@ -443,7 +443,7 @@ subtest 'Koha::Patrons->delete' => sub { $patron1 = $builder->build_object({ class => 'Koha::Patrons' }); $id1 = $patron1->borrowernumber; $set = Koha::Patrons->search({ borrowernumber => { '>=' => $id1 }}); - throws_ok { $set->delete } 'Koha::Exceptions::Patron::Delete', + throws_ok { $set->delete } 'Koha::Exceptions::Patron::FailedDelete', 'Exception raised for deleting patron'; }; -- 2.1.4