From 78300b6320f8943f550cdfe2b0596d373753178e Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 8 Nov 2018 15:13:20 +0000 Subject: [PATCH] Bug 18530: Remove event attributes from patron clubs templates This patch removes event attributes like "onclick" from patron clubs templates in favor of putting these event handlers in the JavaScript. To test, apply the patch and go to Tools -> Patron clubs. - Test deletion of both club templates and clubs. Deletion confirmation dialogs should work as expected, both for OK and Cancel. - Test editing of a club template. Under "Club fields," the "Add new field" and "Delete field" links should work correctly. - Open a patron record for checkout. - Test enrolling and un-enrolling the patron. - Test the same process from the patron detail page. --- .../prog/en/modules/clubs/patron-clubs-tab.tt | 33 --------- .../prog/en/modules/clubs/patron-enroll.tt | 30 -------- .../prog/en/modules/clubs/templates-add-modify.tt | 24 +++++-- koha-tmpl/intranet-tmpl/prog/js/members.js | 80 ---------------------- .../intranet-tmpl/prog/js/pages/circulation.js | 2 +- 5 files changed, 21 insertions(+), 148 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt index b6a8e7a..ad65078 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt @@ -61,36 +61,3 @@ [% END %] - -[% IF CAN_user_clubs_enroll %] - -[% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt index 95a7d8b..86a1f13 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt @@ -35,33 +35,3 @@ - - - diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt index 063c55a..2f165b1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt @@ -1,5 +1,6 @@ [% USE Branches %] [% USE AuthorisedValues %] +[% SET footerjs = 1 %] [% INCLUDE 'doc-head-open.inc' %] Koha › Tools › Patron clubs › [% IF club_template %] @@ -9,7 +10,7 @@ [% END %] [% INCLUDE 'doc-head-close.inc' %] -