Bugzilla – Attachment 82377 Details for
Bug 21796
Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21796: Don't unlock checkouts if restriction exists but fines are below limit
Bug-21796-Dont-unlock-checkouts-if-restriction-exi.patch (text/plain), 1.75 KB, created by
Marcel de Rooy
on 2018-11-16 06:54:19 UTC
(
hide
)
Description:
Bug 21796: Don't unlock checkouts if restriction exists but fines are below limit
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-11-16 06:54:19 UTC
Size:
1.75 KB
patch
obsolete
>From dd07fc3bb4862c40409db33a87936cb73c096dd0 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Thu, 1 Nov 2018 13:01:48 +0000 >Subject: [PATCH] Bug 21796: Don't unlock checkouts if restriction exists but > fines are below limit >Content-Type: text/plain; charset=utf-8 > >The checkout form will be removed if various conditions are >met: Restrictions, a fine above noissuescharge etc. > >Bug 19933 changed the conditions, so a restriction will no longer >block checkouts, if the fines are below the set limit. > >To test: > >- Add a restriction >- Confirm the checkouts form is replaced by a message >- Add a fine below the noissuescharge limit >- Confirm that the form reappears >- Apply the patch >- Check that the checkout form is gone now >- Remove restriction - form should reappear >- Add to the fine, so it's above the limit >- Form should disappear > >Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > circ/circulation.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index 5c858f7..98b011b 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -487,7 +487,7 @@ if ( $patron ) { > my $account = $patron->account; > if( ( my $owing = $account->non_issues_charges ) > 0 ) { > my $noissuescharge = C4::Context->preference("noissuescharge") || 5; # FIXME If noissuescharge == 0 then 5, why?? >- $noissues = ( not C4::Context->preference("AllowFineOverride") and ( $owing > $noissuescharge ) ); >+ $noissues ||= ( not C4::Context->preference("AllowFineOverride") and ( $owing > $noissuescharge ) ); > $template->param( > charges => 1, > chargesamount => $owing, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21796
:
82109
|
82121
|
82201
| 82377