Bugzilla – Attachment 82506 Details for
Bug 21063
Allow columns in intranet ILL request datatable to be customisable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21063: (follow-up) Add user ID to column list
Bug-21063-follow-up-Add-user-ID-to-column-list.patch (text/plain), 3.02 KB, created by
Andrew Isherwood
on 2018-11-19 14:30:41 UTC
(
hide
)
Description:
Bug 21063: (follow-up) Add user ID to column list
Filename:
MIME Type:
Creator:
Andrew Isherwood
Created:
2018-11-19 14:30:41 UTC
Size:
3.02 KB
patch
obsolete
>From 552cda754c7b6ec78f629e536628854071039aad Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Thu, 18 Oct 2018 14:21:36 +0100 >Subject: [PATCH] Bug 21063: (follow-up) Add user ID to column list > >As originally specified in bug 20883, there is a requirement for some >users to be able to display the user ID (borrowernumber) in the UI. > >This patch adds that ability to this bug, 20883 will be marked as a >duplicate of this one. >--- > Koha/REST/V1/Illrequests.pm | 7 ++++--- > admin/columns_settings.yml | 4 ++++ > koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 3 ++- > 3 files changed, 10 insertions(+), 4 deletions(-) > >diff --git a/Koha/REST/V1/Illrequests.pm b/Koha/REST/V1/Illrequests.pm >index 376e272a13..a53b8c6448 100644 >--- a/Koha/REST/V1/Illrequests.pm >+++ b/Koha/REST/V1/Illrequests.pm >@@ -128,9 +128,10 @@ sub list { > foreach my $p(@{$patron_arr}) { > if ($p->{borrowernumber} == $req->borrowernumber) { > $to_push->{patron} = { >- firstname => $p->{firstname}, >- surname => $p->{surname}, >- cardnumber => $p->{cardnumber} >+ borrowernumber => $p->{borrowernumber}, >+ firstname => $p->{firstname}, >+ surname => $p->{surname}, >+ cardnumber => $p->{cardnumber} > }; > last; > } >diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml >index 88cbde18fd..a5384fa722 100644 >--- a/admin/columns_settings.yml >+++ b/admin/columns_settings.yml >@@ -321,6 +321,10 @@ modules: > - > columnname: orderid > - >+ columnname: patron_borrowernumber >+ - >+ columnname: patron_cardnumber >+ - > columnname: biblio_id > - > columnname: borrowernumber >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index c6b348b11f..dfcbb0d458 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -510,9 +510,10 @@ > <th scope="col">Pages</th> > <th scope="col">Type</th> > <th scope="col">Order ID</th> >+ <th scope="col">Patron ID</th> >+ <th scope="col" class="patron_cardnumber">Patron barcode</th> > <th scope="col">Biblio ID</th> > <th scope="col">Patron</th> >- <th class="patron_cardnumber">Patron barcode</th> > <th scope="col">Branch</th> > <th scope="col">Status</th> > <th scope="col" class="placed"> </th> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21063
:
76940
|
76941
|
76942
|
76943
|
79559
|
79560
|
80690
|
80691
|
80802
|
80841
|
82153
|
82154
|
82155
|
82156
|
82504
|
82505
|
82506
|
82507
|
84405
|
84786
|
84787
|
84788
|
84789
|
84790
|
84862
|
85854
|
85855
|
85869
|
85889
|
85893
|
85894
|
85895
|
85896
|
86060
|
86092
|
86093
|
86094
|
86095
|
86096
|
86097
|
86098
|
86099
|
86100
|
86101
|
86102
|
86103
|
86104
|
86105
|
86106
|
86235