Bugzilla – Attachment 84014 Details for
Bug 21326
Add branch param to C4::SIP->checkout
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21326: C4::SIP::ILS add missing branch param
Bug-21326-C4SIPILS-add-missing-branch-param.patch (text/plain), 1.93 KB, created by
Ethan
on 2019-01-15 21:01:12 UTC
(
hide
)
Description:
Bug 21326: C4::SIP::ILS add missing branch param
Filename:
MIME Type:
Creator:
Ethan
Created:
2019-01-15 21:01:12 UTC
Size:
1.93 KB
patch
obsolete
>From 94e0dd87e62dd4cc7dd8add50c6223d74f7937bd Mon Sep 17 00:00:00 2001 >From: Benjamin Rokseth <benjamin.rokseth@deichman.no> >Date: Sun, 9 Sep 2018 23:22:18 +0200 >Subject: [PATCH] Bug 21326: C4::SIP::ILS add missing branch param > >ILS::Transaction was missing branch param for unknown reason. >Since every transactions needs a branch, it makes sense to include it in >the object and allow as param. > >This patch only adds the param to the object and ILS->checkout so it >can be used in submodules. > >Signed-off-by: Ethan Amohia <ethan.amohia@gmail.com> >--- > C4/SIP/ILS.pm | 4 +++- > C4/SIP/ILS/Transaction.pm | 3 ++- > 2 files changed, 5 insertions(+), 2 deletions(-) > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 1bd23c6429..4db34efd24 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -126,7 +126,7 @@ sub offline_ok { > # the response. > # > sub checkout { >- my ( $self, $patron_id, $item_id, $sc_renew, $fee_ack ) = @_; >+ my ( $self, $patron_id, $item_id, $sc_renew, $fee_ack, $branch ) = @_; > my ( $patron, $item, $circ ); > > $circ = C4::SIP::ILS::Transaction::Checkout->new(); >@@ -134,6 +134,8 @@ sub checkout { > # BEGIN TRANSACTION > $circ->patron( $patron = C4::SIP::ILS::Patron->new($patron_id) ); > $circ->item( $item = C4::SIP::ILS::Item->new($item_id) ); >+ $circ->branch( $branch ); >+ > if ($fee_ack) { > $circ->fee_ack($fee_ack); > } >diff --git a/C4/SIP/ILS/Transaction.pm b/C4/SIP/ILS/Transaction.pm >index 011aa980b3..658032987c 100644 >--- a/C4/SIP/ILS/Transaction.pm >+++ b/C4/SIP/ILS/Transaction.pm >@@ -15,6 +15,7 @@ my %fields = ( > ok => 0, > patron => undef, > item => undef, >+ branch => undef, > desensitize => 0, > alert => '', > transaction_id=> undef, >@@ -23,7 +24,7 @@ my %fields = ( > sip_currency => 'USD', # FIXME: why hardcoded? > screen_msg => '', > print_line => '', >- fee_ack => 'N', >+ fee_ack => 'N', > ); > > our $AUTOLOAD; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21326
:
78541
| 84014