Bugzilla – Attachment 86997 Details for
Bug 22579
Split actions in z3950 search results so Import is the main action and make clicking title pop up Card Preview
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22579: Add syspref to toggle dropdown/links in Z39.50 search results
Bug-22579-Add-syspref-to-toggle-dropdownlinks-in-Z.patch (text/plain), 7.12 KB, created by
Hayley Pelham
on 2019-03-26 01:33:54 UTC
(
hide
)
Description:
Bug 22579: Add syspref to toggle dropdown/links in Z39.50 search results
Filename:
MIME Type:
Creator:
Hayley Pelham
Created:
2019-03-26 01:33:54 UTC
Size:
7.12 KB
patch
obsolete
>From 6e4f9680409e2b4716d2fdad8dd8e8864c3f3062 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Wed, 20 Mar 2019 06:45:54 +0000 >Subject: [PATCH] Bug 22579: Add syspref to toggle dropdown/links in Z39.50 > search results > >This patch reduces the number of clicks to use 'Card preview' functionality >without removing the work done to condense the three links into a menu >in Bug 19939 which is displayed by default (and when the syspref is >disabled). > >Test plan: >1) Apply the patch >2) In Cataloging click the New from Z39.50/SRU button and search for a >term that will produce results >3) In the results window, note that the actions column contains a >dropdown for each row which contains three links. >4) Change the Replacez3950CatalogingActionMenuWithLinks to 'Do' >5) Complete step 2 again, and instead note that the actions column now >contains three links, Card preview, MARC preview, Import >6) Verify that each of the links work as expected >7) Sign off! > >Sponsored-by: Horowhenua Library Trust >--- > ..._reduce_clicks_to_views_z39.50_card_preview.sql | 1 + > .../en/modules/admin/preferences/cataloguing.pref | 7 ++++++ > .../prog/en/modules/cataloguing/z3950_search.tt | 27 ++++++++++++++-------- > 3 files changed, 26 insertions(+), 9 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/wr308955_reduce_clicks_to_views_z39.50_card_preview.sql > >diff --git a/installer/data/mysql/atomicupdate/wr308955_reduce_clicks_to_views_z39.50_card_preview.sql b/installer/data/mysql/atomicupdate/wr308955_reduce_clicks_to_views_z39.50_card_preview.sql >new file mode 100644 >index 0000000000..2e612cbedb >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/wr308955_reduce_clicks_to_views_z39.50_card_preview.sql >@@ -0,0 +1 @@ >+INSERT IGNORE INTO systempreferences (variable, value, options, explanation) VALUES ('Replacez3950CatalogingActionMenuWithLinks', 0, 'YesNo', 'Replace z39.50 cataloging action menu with three links: MARC preview, Card preview and Import, to reduce clicks for accessing preview functionality.'); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >index 99e79e8222..2ddd2aee28 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >@@ -248,6 +248,13 @@ Cataloging: > - "<li>value of 001</li>" > - "<li>subfields a and b of fields 245</li>" > - "<li>all subfields of fields 600</li>" >+ - >+ - pref: Replacez3950CatalogingActionMenuWithLinks >+ choices: >+ yes: "Do" >+ no: "Don't" >+ - "replace z39.50 cataloging action menu with three links: MARC preview, Card preview and Import, reducing clicks for accessing preview functionality." >+ > Importing: > - > - When matching on ISBN with the record import tool, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >index 0a01aee147..1453dc74de 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >@@ -7,6 +7,7 @@ > [% INCLUDE 'doc-head-close.inc' %] > <style> > #dataPreview { width : 90%; top: 5%; } .modal-body { max-height: 380px; } .modal-header { padding: 0 14px; } @media (max-width: 767px) { #dataPreview { margin: 0; width : auto; } } >+.linktools { display: block; white-space: nowrap; } .linktools a { font-size : 75%; display:block;text-decoration:none;} .linktools a {margin:0 2px;padding:2px;background-color:#FFF;text-align:center; } .linktools a:first-child { border-bottom: 1px solid #DDD; } .linktools a:nth-child(2){ border-bottom: 1px solid #DDD; } .linktools a:hover { background-color: #FFC; } > </style> > </head> > >@@ -131,16 +132,24 @@ > </td> > [% END %] > <td> >- <div class="dropdown"> >- <a class="btn btn-default btn-xs dropdown-toggle" id="cataloguesearchactions[% breeding_loo.breedingid | html %]" role="button" data-toggle="dropdown" href="#"> >+ [% IF Koha.Preference('Replacez3950CatalogingActionMenuWithLinks') == 1 %] >+ <span class="linktools"> >+ <a href="/cgi-bin/koha/catalogue/showmarc.pl?importid=[% breeding_loo.breedingid | uri %]" title="MARC" class="previewData">MARC preview</a> >+ <a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&importid=[% breeding_loo.breedingid | uri %]" title="Card" class="previewData">Card preview</a> >+ <a href="#" class="import_record" data-breedingid="[% breeding_loo.breedingid | html %]" data-biblionumber="[% breeding_loo.biblionumber | html %]" data-frameworkcode="[% frameworkcode | uri %]">Import</a> >+ </span> >+ [% ELSE %] >+ <div class="dropdown"> >+ <a class="btn btn-default btn-xs dropdown-toggle" id="cataloguesearchactions[% breeding_loo.breedingid | html %]" role="button" data-toggle="dropdown" href="#"> > Actions <b class="caret"></b> >- </a> >- <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="cataloguesearchactions[% breeding_loo.breedingid | html %]"> >- <li><a href="/cgi-bin/koha/catalogue/showmarc.pl?importid=[% breeding_loo.breedingid | uri %]" title="MARC" class="previewData"><i class="fa fa-eye"></i> MARC preview</a></li> >- <li><a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&importid=[% breeding_loo.breedingid | uri %]" title="Card" class="previewData"><i class="fa fa-eye"></i> Card preview</a></li> >- <li><a href="#" class="import_record" data-breedingid="[% breeding_loo.breedingid | html %]" data-biblionumber="[% breeding_loo.biblionumber | html %]" data-frameworkcode="[% frameworkcode | uri %]"><i class="fa fa-download"></i> Import</a></li> >- </ul> >- </div> >+ </a> >+ <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="cataloguesearchactions[% breeding_loo.breedingid | html %]"> >+ <li><a href="/cgi-bin/koha/catalogue/showmarc.pl?importid=[% breeding_loo.breedingid | uri %]" title="MARC" class="previewData"><i class="fa fa-eye"></i> MARC preview</a></li> >+ <li><a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&importid=[% breeding_loo.breedingid | uri %]" title="Card" class="previewData"><i class="fa fa-eye"></i> Card preview</a></li> >+ <li><a href="#" class="import_record" data-breedingid="[% breeding_loo.breedingid | html %]" data-biblionumber="[% breeding_loo.biblionumber | html %]" data-frameworkcode="[% frameworkcode | uri %]"><i class="fa fa-download"></i> Import</a></li> >+ </ul> >+ </div> >+ [% END %] > </td> > </tr> > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22579
:
86997
|
101783
|
104998
|
105054
|
105055
|
105056
|
113206
|
113207