From f7ed576db535486cb32cdd5fdb95e64b9ea80875 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 10 May 2019 13:24:39 +0000 Subject: [PATCH] Bug 22881: Trying to clear search history via the navbar X doesn't clear any searches This patch undoes a mistake introduced in my patch for Bug 21479. A "preventDefault()" was added to the search history clear button by mistake. The "confirmDelete" function only works if the default action of the link is allowed to complete. To test you must have the EnableOpacSearchHistory system preference enabled. Apply the patch and log into the OPAC as a patron who has a search history. Click the "X" link in the header next to the "Search history" link. Confirm that you want to clear your search history. The page should refresh. Navigate to your account -> Your search history to confirm that your search history has been cleared. Signed-off-by: Jonathan Druart --- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc index f51f990ef7..ffeebcdb18 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ -199,8 +199,7 @@ $.widget.bridge('uitooltip', $.ui.tooltip); var biblionumber = $(this).data("biblionumber"); delSingleRecord( biblionumber ); }); - $(".clearsh").on("click", function(e){ - e.preventDefault(); + $(".clearsh").on("click", function(){ return confirmDelete(MSG_DELETE_SEARCH_HISTORY); }); //]]> -- 2.11.0