Bugzilla – Attachment 91046 Details for
Bug 11999
Add two checks in CanBookBeReserved and CanItemBeReserved
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11999: QA follow-up
Bug-11999-QA-follow-up.patch (text/plain), 1.79 KB, created by
Arthur Suzuki
on 2019-06-27 08:52:25 UTC
(
hide
)
Description:
Bug 11999: QA follow-up
Filename:
MIME Type:
Creator:
Arthur Suzuki
Created:
2019-06-27 08:52:25 UTC
Size:
1.79 KB
patch
obsolete
>From cffabec55e5b6804cdeeafecfcfeec7315e6186e Mon Sep 17 00:00:00 2001 >From: Arthur Suzuki <arthur.suzuki@biblibre.com> >Date: Wed, 26 Jun 2019 12:36:07 +0200 >Subject: [PATCH] Bug 11999: QA follow-up > >--- > C4/Reserves.pm | 4 ++-- > reserve/request.pl | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index cedd8f7410..153dfac3e5 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -326,7 +326,7 @@ sub CanBookBeReserved{ > { status => libraryNotFound }, if given branchcode is not an existing library > { status => libraryNotPickupLocation }, if given branchcode is not configured to be a pickup location > { status => cannotBeTransferred }, if branch transfer limit applies on given item and branchcode >- { status => alreadyReserved }, if the borrower has already reserved this item. >+ { status => alreadyReserved }, if the borrower has already reserved this item. > > =cut > >@@ -408,7 +408,7 @@ sub CanItemBeReserved { > $ruleitemtype = '*'; > } > >- my $holds = Koha::Holds->search( >+ $holds = Koha::Holds->search( > { > borrowernumber => $borrowernumber, > biblionumber => $item->biblionumber, >diff --git a/reserve/request.pl b/reserve/request.pl >index 3d6a1e4706..5f775b3e73 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -242,8 +242,8 @@ foreach my $biblionumber (@biblionumbers) { > } > elsif ( grep { $canReserve->{status} eq $_ } > (qw(ageRestricted alreadyReserved none_available)) ) >- { >- $template->param( $canReserve->{status} => 1 ); >+ { >+ $template->param( $canReserve->{status} => 1 ); > $biblioloopiter{ $canReserve->{status} } = 1; > } > else { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11999
:
26589
|
28986
|
31524
|
35697
|
36358
|
36404
|
36630
|
38397
|
41951
|
41952
|
44631
|
44632
|
46262
|
46263
|
50224
|
50225
|
58741
|
58742
|
58743
|
63593
|
63594
|
63595
|
66267
|
66268
|
66269
|
66270
|
88300
|
88301
|
88302
|
88303
|
90142
|
90143
|
90144
|
90146
|
90147
|
91046
|
91402
|
91403
|
91479
|
91481
|
91494
|
91580
|
91581
|
91582
|
91590
|
91591
|
91592
|
91593
|
99927
|
99928
|
106481
|
106494
|
111687
|
111688
|
111689
|
112871
|
112872
|
112873
|
112874
|
120776
|
120777
|
120778
|
120779
|
120780
|
121531
|
121612