Bugzilla – Attachment 91222 Details for
Bug 23230
Make Koha::Plugins::Base::_version_compare OO
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23230: (follow-up) Fix broken tests
Bug-23230-follow-up-Fix-broken-tests.patch (text/plain), 1.08 KB, created by
Kyle M Hall
on 2019-07-03 11:17:27 UTC
(
hide
)
Description:
Bug 23230: (follow-up) Fix broken tests
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2019-07-03 11:17:27 UTC
Size:
1.08 KB
patch
obsolete
>From 24d2cea9aefbea751f404e591d13615769f739f1 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 3 Jul 2019 02:35:16 +0000 >Subject: [PATCH] Bug 23230: (follow-up) Fix broken tests > >Before patch, the new tests don't run. >After patch, they do. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/Plugins.t | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/t/db_dependent/Plugins.t b/t/db_dependent/Plugins.t >index 3db0adb627..a667434d20 100755 >--- a/t/db_dependent/Plugins.t >+++ b/t/db_dependent/Plugins.t >@@ -290,6 +290,8 @@ subtest 'Test _version_compare' => sub { > > plan tests => 12; > >+ t::lib::Mocks::mock_config( 'enable_plugins', 1 ); >+ > is( Koha::Plugins::Base::_version_compare( '1.1.1', '2.2.2' ), -1, "1.1.1 is less then 2.2.2" ); > is( Koha::Plugins::Base::_version_compare( '2.2.2', '1.1.1' ), 1, "1.1.1 is greater then 2.2.2" ); > is( Koha::Plugins::Base::_version_compare( '1.1.1', '1.1.1' ), 0, "1.1.1 is equal to 1.1.1" ); >-- >2.20.1 (Apple Git-117)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23230
:
91152
|
91153
|
91201
|
91202
|
91203
|
91204
|
91220
|
91221
| 91222