Bugzilla – Attachment 92444 Details for
Bug 23493
jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23493: Replace rowGrouping with rowGroup
Bug-23493-Replace-rowGrouping-with-rowGroup.patch (text/plain), 5.15 KB, created by
Martin Renvoize
on 2019-08-23 11:11:30 UTC
(
hide
)
Description:
Bug 23493: Replace rowGrouping with rowGroup
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2019-08-23 11:11:30 UTC
Size:
5.15 KB
patch
obsolete
>From 63555a718511361e05fe1b6cd3fe2f48ec01d0d2 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 23 Aug 2019 10:52:11 +0100 >Subject: [PATCH] Bug 23493: Replace rowGrouping with rowGroup > >This is an initial attempt to get some feedback. >--- > .../prog/en/modules/circ/circulation.tt | 3 +- > .../prog/en/modules/members/moremember.tt | 3 +- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 29 ++++++++----------- > 3 files changed, 16 insertions(+), 19 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 5fb4889bed..6251485236 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -10,6 +10,7 @@ > [% USE AuthorisedValues %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >+<link type="text/css" rel="stylesheet" href="https://cdn.datatables.net/rowgroup/1.1.0/css/rowGroup.dataTables.min.css"> > [% SET destination = "circ" %] > <title> > Koha › Circulation >@@ -984,7 +985,7 @@ > [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %] > [% Asset.js("lib/jquery/plugins/jquery-ui-timepicker-addon.min.js") | $raw %] > [% INCLUDE 'timepicker.inc' %] >- [% Asset.js("lib/jquery/plugins/jquery.dataTables.rowGrouping.js") | $raw %] >+ <script src="https://cdn.datatables.net/rowgroup/1.1.0/js/dataTables.rowGroup.min.js"></script> > [% Asset.js("js/pages/circulation.js") | $raw %] > [% Asset.js("js/checkouts.js") | $raw %] > [% Asset.js("js/holds.js") | $raw %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 95ad755bca..abedd12cc8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -8,6 +8,7 @@ > [% USE Price %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] >+<link type="text/css" rel="stylesheet" href="https://cdn.datatables.net/rowgroup/1.1.0/css/rowGroup.dataTables.min.css"> > <title>Koha › Patrons › > [% UNLESS blocking_error %] > Patron details for [% INCLUDE 'patron-title.inc' no_html = 1 %] >@@ -823,13 +824,13 @@ > > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] >+ <script src="https://cdn.datatables.net/rowgroup/1.1.0/js/dataTables.rowGroup.min.js"></script> > [% INCLUDE 'columns_settings.inc' %] > [% INCLUDE 'strings.inc' %] > [% INCLUDE 'calendar.inc' %] > [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %] > [% Asset.js("lib/jquery/plugins/jquery-ui-timepicker-addon.min.js") | $raw %] > [% INCLUDE 'timepicker.inc' %] >- [% Asset.js("lib/jquery/plugins/jquery.dataTables.rowGrouping.js") | $raw %] > [% Asset.js("js/pages/circulation.js") | $raw %] > [% Asset.js("js/checkouts.js") | $raw %] > [% Asset.js("js/holds.js") | $raw %] >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index da69276e4a..75eb34c91b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -573,19 +573,20 @@ $(document).ready(function() { > fnCallback(json) > } ); > }, >+ "rowGroup":{ >+ "dataSrc": "issued_today", >+ "startRender": function ( rows, group ) { >+ if ( group ) { >+ return $('<tr/>').append("<td colspan='100%'><strong>" + TODAYS_CHECKOUTS + "</strong></td>"); >+ } else { >+ return $('<tr/>').append("<td colspan='100%'><strong>" + PREVIOUS_CHECKOUTS + "</strong></td>"); >+ } >+ } >+ }, > "fnInitComplete": function(oSettings, json) { > // Disable rowGrouping plugin after first use > // so any sorting on the table doesn't use it >- var oSettings = issuesTable.fnSettings(); >- >- for (f = 0; f < oSettings.aoDrawCallback.length; f++) { >- if (oSettings.aoDrawCallback[f].sName == 'fnRowGrouping') { >- oSettings.aoDrawCallback.splice(f, 1); >- break; >- } >- } >- >- oSettings.aaSortingFixed = null; >+ //var oSettings = issuesTable.fnSettings(); > > // Build a summary of checkouts grouped by itemtype > var checkoutsByItype = json.aaData.reduce(function (obj, row) { >@@ -605,13 +606,7 @@ $(document).ready(function() { > .append(ul) > .insertBefore(oSettings.nTableWrapper) > }, >- }, columns_settings_issues_table).rowGrouping( >- { >- iGroupingColumnIndex: 1, >- iGroupingOrderByColumnIndex: 0, >- sGroupingColumnSortDirection: "asc" >- } >- ); >+ }, columns_settings_issues_table); > > if ( $("#issues-table").length ) { > $("#issues-table_processing").position({ >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23493
:
92443
|
92444
|
97324
|
97344
|
97694
|
97704
|
98041
|
98042
|
98055
|
98056
|
98118
|
98132