Bugzilla – Attachment 92837 Details for
Bug 22145
Add a syspref to hide the 'rows per page' dropdown when running a report
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Fixed patch
koha-bug-22145-revised-patch.diff (text/plain), 3.69 KB, created by
Paul Hoffman
on 2019-09-16 16:44:18 UTC
(
hide
)
Description:
Fixed patch
Filename:
MIME Type:
Creator:
Paul Hoffman
Created:
2019-09-16 16:44:18 UTC
Size:
3.69 KB
patch
obsolete
>@@ -, +, @@ > reports print layout >--- > .../bug_20679_-_add_reportRowsPerPage_syspref.sql | 1 + > installer/data/mysql/sysprefs.sql | 1 + > .../en/modules/admin/preferences/web_services.pref | 6 ++++++ > .../en/modules/reports/guided_reports_start.tt | 25 ++++++++++++---------- > 4 files changed, 22 insertions(+), 11 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_20679_-_add_reportRowsPerPage_syspref.sql >--- a/installer/data/mysql/atomicupdate/bug_20679_-_add_reportRowsPerPage_syspref.sql >+++ a/installer/data/mysql/atomicupdate/bug_20679_-_add_reportRowsPerPage_syspref.sql >@@ -0,0 +1, @@ >+INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('reportRowsPerPage', '1', NULL, 'Show/hide the rows per page dropdown when running a report', 'YesNo'); >--- a/installer/data/mysql/sysprefs.sql >+++ a/installer/data/mysql/sysprefs.sql >@@ -480,6 +480,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('RentalsInNoissuesCharge','1',NULL,'Rental charges block checkouts (added to noissuescharge).','YesNo'), > ('ReplyToDefault','',NULL,'Use this email address as the replyto in emails','Free'), > ('ReportsLog','0',NULL,'If ON, log information about reports.','YesNo'), >+('reportRowsPerPage', '1', NULL, 'Show/hide the rows per page dropdown when running a report', 'YesNo'), > ('RequestOnOpac','1',NULL,'If ON, globally enables patron holds on OPAC','YesNo'), > ('RequireStrongPassword','1','','Require a strong login password for staff and patrons','YesNo'), > ('ReservesControlBranch','PatronLibrary','ItemHomeLibrary|PatronLibrary','Branch checked for members reservations rights','Choice'), >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref >+++ a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref >@@ -65,6 +65,12 @@ Web services: > - pref: SvcMaxReportRows > class: integer > - rows of a report requested via the reports web service. >+ - >+ - pref: reportRowsPerPage >+ choices: >+ yes: Show >+ no: "Don't show" >+ - rows per page option when running a report. > IdRef: > - > - pref: IdRef >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -714,17 +714,20 @@ canned reports and writing custom SQL reports.</p> > <input type="hidden" name="param_name" value="[% n | html %]"/> > [% END %] > >- <label for="limit">Rows per page: </label> >- <select name="limit" id="limit"> >- [% limits = [ 10, 20, 50, 100, 200, 300, 400, 500, 1000 ] %] >- [% FOREACH l IN limits %] >- [% IF l == limit %] >- <option value="[% l | html %]" selected="selected">[% l | html %]</option> >- [% ELSE %] >- <option value="[% l | html %]">[% l | html %]</option> >- [% END %] >- [% END %] >- </select> >+ [% IF ( Koha.Preference('reportRowsPerPage') ) %] >+ <label for="limit">Rows per page: </label> >+ <select name="limit" id="limit"> >+ [% limits = [ 10, 20, 50, 100, 200, 300, 400, 500, 1000 ] %] >+ [% FOREACH l IN limits %] >+ [% IF l == limit %] >+ <option value="[% l | html %]" selected="selected">[% l | html %]</option> >+ [% ELSE %] >+ <option value="[% l | html %]">[% l | html %]</option> >+ [% END %] >+ [% END %] >+ </select> >+ [% END %] >+ > </form> > > <div class="pages">[% pagination_bar | $raw %]</div> >--
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22145
:
84086
|
92837