Bugzilla – Attachment 94722 Details for
Bug 23413
Add a holds routine to Koha::Items to fetch related holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23413: Fix tests
Bug-23413-Fix-tests.patch (text/plain), 1.54 KB, created by
Jonathan Druart
on 2019-10-25 09:43:08 UTC
(
hide
)
Description:
Bug 23413: Fix tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-10-25 09:43:08 UTC
Size:
1.54 KB
patch
obsolete
>From 1090e9f767f7aee7c4223984598a751040bca5b9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 25 Oct 2019 11:42:50 +0200 >Subject: [PATCH] Bug 23413: Fix tests > >--- > t/db_dependent/Koha/Items.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Items.t b/t/db_dependent/Koha/Items.t >index 0d601b1e19..5f97d46c06 100644 >--- a/t/db_dependent/Koha/Items.t >+++ b/t/db_dependent/Koha/Items.t >@@ -82,7 +82,7 @@ subtest 'holds' => sub { > biblionumber => $biblio->biblionumber, > }); > $nb_of_items++; >- is($item->holds(), undef, "Nothing returned if no holds"); >+ is($item->holds->count, 0, "Nothing returned if no holds"); > my $hold1 = $builder->build({ source => 'Reserve', value => { itemnumber=>$item->itemnumber, found => 'T' }}); > my $hold2 = $builder->build({ source => 'Reserve', value => { itemnumber=>$item->itemnumber, found => 'W' }}); > my $hold3 = $builder->build({ source => 'Reserve', value => { itemnumber=>$item->itemnumber, found => 'W' }}); >@@ -90,7 +90,7 @@ subtest 'holds' => sub { > is($item->holds()->count,3,"Three holds found"); > is($item->holds({found => 'W'})->count,2,"Two waiting holds found"); > is_deeply($item->holds({found => 'T'})->next->unblessed,$hold1,"Found transit holds matches the hold"); >- is($item->holds({found => undef}),undef,"Nothing returned if no matching holds"); >+ is($item->holds({found => undef})->count, 0,"Nothing returned if no matching holds"); > }; > > subtest 'biblio' => sub { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23413
:
91912
|
92123
|
92128
|
92129
|
92542
|
92543
|
92544
|
94686
| 94722