Bugzilla – Attachment 94983 Details for
Bug 23847
Custom item search fields don't work if subfield is 0 (e.g. Withdrawn)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23847: Fix custom item search fields if subfield is '0'
Bug-23847-Fix-custom-item-search-fields-if-subfiel.patch (text/plain), 1.62 KB, created by
Katrin Fischer
on 2019-11-03 21:56:38 UTC
(
hide
)
Description:
Bug 23847: Fix custom item search fields if subfield is '0'
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-11-03 21:56:38 UTC
Size:
1.62 KB
patch
obsolete
>From 6427c20b427d6249022db9a1158ca806344391e6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 21 Oct 2019 09:37:25 +0200 >Subject: [PATCH] Bug 23847: Fix custom item search fields if subfield is '0' > >The subfield is not used if is false, so if 0. We want to test if the >subfield is defined and not an empty string. > >Test plan: >- Define a new custom item search fields using a subfield '0' >(withdrawn=952$0 for instance) >- Define one which does not have a subfield (control field) >- Search items using those newly created fields. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >index 8c9a625dc3..ee1b43ea74 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >@@ -74,7 +74,7 @@ > <optgroup label="Custom search fields"> > [% FOREACH field IN items_search_fields %] > [% marcfield = field.tagfield %] >- [% IF field.tagsubfield %] >+ [% IF field.tagsubfield.defined AND field.tagsubfield != "" %] > [% marcfield = marcfield _ '$' _ field.tagsubfield %] > [% END %] > <option value="marc:[% marcfield | html %]" data-authorised-values-category="[% field.authorised_values_category | html %]">[% field.label | html %] ([% marcfield | html %])</option> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23847
:
94423
|
94983
|
95194