Bugzilla – Attachment 97126 Details for
Bug 24389
Claiming an order can display an invalid successful message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24389: Better error handle when claiming late orders
Bug-24389-Better-error-handle-when-claiming-late-o.patch (text/plain), 1.78 KB, created by
Jonathan Druart
on 2020-01-09 17:06:38 UTC
(
hide
)
Description:
Bug 24389: Better error handle when claiming late orders
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-01-09 17:06:38 UTC
Size:
1.78 KB
patch
obsolete
>From 465e580ab7cff88a66d8248d72235b3de2e7d5ac Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 16 Dec 2019 17:15:19 +0100 >Subject: [PATCH] Bug 24389: Better error handle when claiming late orders > >A successful message says that the email has been sent and the order has >been claimed, but nothing happened. > >Test plan: >0. Do not apply this patch >1. Create a new vendor, does not create a contact >2. Create some orders, close the basket >3. Go to the late orders page and claims some orders >=> You get a successful message, but the claim has not been done! >4. Apply this patch >5. Claim the orders >=> You get an error >6. Set a contact for the vendor >7. Claim the orders >=> Success > >In the docker container, you may need to: >% apt install postfix >% postfix start >Edit /etc/hosts >127.0.0.1 localhost localhost.localdomain >--- > acqui/lateorders.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/acqui/lateorders.pl b/acqui/lateorders.pl >index 9febcf65c9..e72ba350f0 100755 >--- a/acqui/lateorders.pl >+++ b/acqui/lateorders.pl >@@ -111,12 +111,12 @@ if ($op and $op eq "send_alert"){ > } > }; > >- if ( $@ ) { >- $template->param(error_claim => $@); >- } elsif ( ref $err and exists $err->{error} and $err->{error} eq "no_email" ) { >+ if ( ref $err and exists $err->{error} and $err->{error} eq "no_email" ) { > $template->{VARS}->{'error_claim'} = "no_email"; > } elsif ( ref $err and exists $err->{error} and $err->{error} eq "no_order_selected"){ > $template->{VARS}->{'error_claim'} = "no_order_selected"; >+ } elsif ( $@ or ref $err and exists $err->{error} ) { >+ $template->param(error_claim => $@ || $err->{error}); > } else { > $template->{VARS}->{'info_claim'} = 1; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24389
:
97126
|
98178
|
99081