Bugzilla – Attachment 98083 Details for
Bug 24526
Add verbose and test modes to the `automatic_renewals.pl` cronjob
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24526: (follow-up) clean up verbose conditional
Bug-24526-follow-up-clean-up-verbose-conditional.patch (text/plain), 1.49 KB, created by
ByWater Sandboxes
on 2020-01-29 14:06:36 UTC
(
hide
)
Description:
Bug 24526: (follow-up) clean up verbose conditional
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2020-01-29 14:06:36 UTC
Size:
1.49 KB
patch
obsolete
>From f4c58bbbce8ab4340301ee8ec1e05c23406468ee Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 29 Jan 2020 13:48:09 +0000 >Subject: [PATCH] Bug 24526: (follow-up) clean up verbose conditional > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > misc/cronjobs/automatic_renewals.pl | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/automatic_renewals.pl b/misc/cronjobs/automatic_renewals.pl >index 547100afb8..a5667e5f39 100755 >--- a/misc/cronjobs/automatic_renewals.pl >+++ b/misc/cronjobs/automatic_renewals.pl >@@ -93,8 +93,10 @@ while ( my $auto_renew = $auto_renews->next ) { > my $date_due = AddRenewal( $auto_renew->borrowernumber, $auto_renew->itemnumber, $auto_renew->branchcode ); > $auto_renew->auto_renew_error(undef)->store; > } >- $verbose && print "Issue id: " . $auto_renew->issue_id . " for borrower: " . $auto_renew->borrowernumber . " and item: " . $auto_renew->itemnumber; >- $verbose && $commit ? print " will be renewed.\n" : print " would be renewed.\n"; >+ if ( $verbose ){ >+ print "Issue id: " . $auto_renew->issue_id . " for borrower: " . $auto_renew->borrowernumber . " and item: " . $auto_renew->itemnumber; >+ $commit ? print " will be renewed.\n" : print " would be renewed.\n"; >+ } > push @{ $report{ $auto_renew->borrowernumber } }, $auto_renew; > } elsif ( $error eq 'too_many' > or $error eq 'on_reserve' >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24526
:
98037
|
98059
|
98081
|
98082
|
98083
|
98497
|
98498
|
98499
|
98500
|
98501
|
98520