@@ -, +, @@ t/db_dependent/Holds.t for i in {1..300}; do echo "loop $i"; prove t/db_dependent/Koha/Item.t t/db_dependent/Holds.t; if [ "$?" = "1" ]; then break; fi; done --- t/db_dependent/Holds.t | 6 +++--- t/db_dependent/Koha/Item.t | 15 ++++++--------- 2 files changed, 9 insertions(+), 12 deletions(-) --- a/t/db_dependent/Holds.t +++ a/t/db_dependent/Holds.t @@ -1055,9 +1055,9 @@ subtest 'CanItemBeReserved / pickup_not_in_hold_group' => sub { my $itemtype2 = $builder->build_object( { class => 'Koha::ItemTypes' } ); # Create libraries - my $library1 = $builder->build_object( { class => 'Koha::Libraries' } ); - my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); - my $library3 = $builder->build_object( { class => 'Koha::Libraries' } ); + my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); + my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); + my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } ); # Create library groups hierarchy my $rootgroup = $builder->build_object( { class => 'Koha::Library::Groups', value => {ft_local_hold_group => 1} } ); --- a/t/db_dependent/Koha/Item.t +++ a/t/db_dependent/Koha/Item.t @@ -169,14 +169,12 @@ subtest 'pickup_locations' => sub { } ); - my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); - my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } ); - - my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1 } } ); - my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1 } } ); - my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0 } } ); - my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1 } } ); - + my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); + my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } ); + my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST1' } } ); + my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST2' } } ); + my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, branchcode => 'TEST3' } } ); + my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST4' } } ); my $group1_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library1->branchcode } } ); my $group1_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library2->branchcode } } ); @@ -289,7 +287,6 @@ subtest 'pickup_locations' => sub { foreach my $pickup_location (@pl) { is( ref($pickup_location), 'Koha::Library', 'Object type is correct' ); } - ok( scalar(@pl) == $results->{ $item->barcode . '-' --