From 5d8c3f3e3334f2ece98f1a9ded0e2207af2180d1 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 14 Feb 2020 12:58:49 +0000 Subject: [PATCH] Bug 16683: (18.11.x) Help links to fields 59X in cataloguing form are broken This patch adds more specificity to handling of MARC21 documentation links in the basic MARC editor. To test, apply the patch and make sure the "advancedMARCeditor" system preference is set to "Display." You may need to edit a bibliographic framework so that 09x, 59x, and 69x tags will display in the editor. Edit or create a bibliographic record using that framework. Next to each tag label in the editor should be a "?" link. Clicking this link should open a new window with the correct Library of Congress documentation page. Check the links for 09x, 59x, and 69x tags as well as others to confirm they open the correct pages. --- .../prog/en/modules/cataloguing/addbiblio.tt | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt index 4e6b23675b2..fb35c7f9ccd 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt @@ -178,11 +178,17 @@ function PopupMARCFieldDoc(field) { } function _MARC21FieldDoc(field) { - if(field == 0) { - window.open("http://www.loc.gov/marc/bibliographic/bdleader.html"); - } else if (field < 900) { - window.open("http://www.loc.gov/marc/bibliographic/bd" + ("000"+field).slice(-3) + ".html"); - } else { + if(field == 0) { + window.open("http://www.loc.gov/marc/bibliographic/bdleader.html"); + } else if (field >= 90 && field <= 99 ){ + window.open("http://www.loc.gov/marc/bibliographic/bd09x.html"); + } else if (field >= 590 && field <= 599 ){ + window.open("http://www.loc.gov/marc/bibliographic/bd59x.html"); + } else if (field >= 690 && field <= 699 ){ + window.open("http://www.loc.gov/marc/bibliographic/bd69x.html"); + } else if (field < 900) { + window.open("http://www.loc.gov/marc/bibliographic/bd" + ("000"+field).slice(-3) + ".html"); + } else { window.open("http://www.loc.gov/marc/bibliographic/bd9xx.html"); } } -- 2.11.0