From 98de38f9b0b448322e1e761acd6e328cd2d587d0 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Mon, 2 Mar 2020 17:27:10 +0300 Subject: [PATCH] Bug 24776: Remove Borrowers.IsDebarred call Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object. Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron". Test plan : 1) Enable system preference SpecifyReturnDate 2) For a patron without restriction create a checkout 3) Create a manual restriction to debarre patron 4) Go to return page and click on "Checkin settings" 5) Specify a date in the past, barcode and click "Check in" 6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted." --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index 29818882c9..3e741dfee6 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -3,7 +3,6 @@ [% USE KohaDates %] [% USE Branches %] [% USE Koha %] -[% USE Borrowers %] [% USE ItemTypes %] [% USE AuthorisedValues %] [% USE ColumnsSettings %] @@ -182,11 +181,11 @@ [% END %] - [% IF return_date_was_overriden && Borrowers.IsDebarred( borrower ) %] + [% IF return_date_was_overriden && issue.patron.is_debarred %]

- - [% patron.firstname | html %] [% patron.surname | html %] + + [% issue.patron.firstname | html %] [% issue.patron.surname | html %] is restricted. Please verify this patron should still be restricted.

-- 2.25.1