Bug 10145

Summary: The acquisition details block is badly placed
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: chris, colin.campbell, dcook, katrin.fischer
Version: 3.12   
Hardware: All   
OS: All   
URL: serials/subscription-detail.pl?subscriptionid=
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 5343    
Bug Blocks:    
Attachments: Bug 10145: The acquisition details block is badly placed.
[SIGNED OFF] Bug 10145: The acquisition details block is badly placed.
[PASSED QA] Bug 10145: The acquisition details block is badly placed.

Description Jonathan Druart 2013-04-29 14:01:28 UTC
Bug 5335 introduced a new "Acquisition details" block on the subscription details page.
It is placed between to tabs and causes an ergonomic issue.
Comment 1 Jonathan Druart 2013-04-29 14:04:13 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2013-04-30 22:54:44 UTC
Can we get a sign off for this? :)
Comment 3 David Cook 2013-05-01 06:32:33 UTC Comment hidden (obsolete)
Comment 4 David Cook 2013-05-01 06:33:24 UTC
Works great.
Comment 5 Katrin Fischer 2013-05-01 06:46:20 UTC
Created attachment 17866 [details] [review]
[PASSED QA] Bug 10145: The acquisition details block is badly placed.

Bug 5335 introduced a new "Acquisition details" block on the
subscription details page.
It is placed between to tabs and causes an ergonomic issue.

Test plan:
- Order a subscription.
- Go on the subscription detail page and select a tab.
- The "Acquisition details" block is moved from the bottom to the top of
the table.
- Apply the patch
- The "Acquisition details" block is always on the bottom of the table.

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes display problem, passes all tests.
Comment 6 Jared Camins-Esakov 2013-05-01 10:28:59 UTC
This patch has been pushed to master and 3.12.x.
Comment 7 Chris Cormack 2013-05-08 07:51:55 UTC
Doesn't apply to 3.10.x please rebase if it is needed
Comment 8 Jonathan Druart 2013-05-13 07:40:18 UTC
(In reply to comment #7)
> Doesn't apply to 3.10.x please rebase if it is needed

Not needed for 3.10.x
In fact, it depends on bug 5343, not 5335.