Bug 10642

Summary: Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm
Product: Koha Reporter: kenza <kenza.zaki>
Component: Architecture, internals, and plumbingAssignee: kenza <kenza.zaki>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: bgkriegel, chrish, gmcharlt, kenza.zaki, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 10653    
Attachments: Bug 10642 : Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm
Bug 10642 : Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm
Bug 10642 : Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm

Description kenza 2013-07-25 11:41:17 UTC

    
Comment 1 kenza 2013-07-25 11:51:45 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-08-08 23:15:31 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-08-16 16:02:33 UTC
Created attachment 20425 [details] [review]
Bug 10642 : Inappropriate uses of $sth->finish() in C4::RotatingCollections.pm

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl, passes UT provided by bug 10653
Comment 4 Galen Charlton 2013-08-16 16:23:00 UTC
Pushed to master.  Thanks, Kenza!
Comment 5 Tomás Cohen Arazi 2013-09-11 17:53:34 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Kenza!
Comment 6 Bernardo Gonzalez Kriegel 2013-09-14 22:38:52 UTC
Pushed to 3.10.x, will be in 3.10.11
Comment 7 Chris Hall 2013-10-21 19:39:26 UTC
Pushed to 3.8.x, will be in 3.8.19.