Bug 10682

Summary: Inappropriate uses of finish() in C4::Reserve.pm
Product: Koha Reporter: kenza <kenza.zaki>
Component: Architecture, internals, and plumbingAssignee: kenza <kenza.zaki>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: bgkriegel, gmcharlt, kenza.zaki
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 10682 : Inappropriate uses of finish() in C4::Reserves
Bug 10682 : Inappropriate uses of finish() in C4::Reserves
Bug 10682 : Inappropriate uses of finish() in C4::Reserves

Description kenza 2013-08-05 09:42:05 UTC

    
Comment 1 kenza 2013-08-05 09:53:14 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-08-25 22:28:32 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2013-08-27 09:42:56 UTC
Created attachment 20646 [details] [review]
Bug 10682 : Inappropriate uses of finish() in C4::Reserves

This patch gets rid of finish.

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Similar to other patches from the same author
I run prove t/db_dependent/Reserves.t without errors
don't know if more tests are needed.
No koha-qa errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 4 Galen Charlton 2013-10-09 03:58:30 UTC
Pushed to master.  Thanks, Kenza!