Summary: | keyword search on reports should search report number | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Reports | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, katrin.fischer, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 14008 | ||
Attachments: |
Bug 10706: Search reports by id
Bug 10706: Search reports by id Bug 10706: Add test Bug 10706: Delete saved_reports to be sure no reports existed [PASSED QA] Bug 10706: Search reports by id [PASSED QA] Bug 10706: Add test [PASSED QA] Bug 10706: Delete saved_reports to be sure no reports existed |
Description
Nicole C. Engard
2013-08-09 23:10:37 UTC
Created attachment 37969 [details] [review] Bug 10706: Search reports by id This patch adds the ability to search reports by their id. Test plan: 1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved) 2/ Search for a report id (refer to the ID column in the table) 3/ The result should be consistent That the filters are not kept, already existed. Created attachment 37988 [details] [review] Bug 10706: Search reports by id This patch adds the ability to search reports by their id. Test plan: 1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved) 2/ Search for a report id (refer to the ID column in the table) 3/ The result should be consistent That the filters are not kept, already existed. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Created attachment 38008 [details] [review] Bug 10706: Add test I found this test this morning in my working directory, could be useful here :) Hi Jonathan, unfunnily... this test seems to delete any existing reports in your database (which is why it failed for me the first time and passed the second time I ran it... ) Could you please fix that even if it's a bit scope creeping? I apologize to the test. It's innocent. But: somehow I manage to make all my reports disappear. Can someone try and confirm? 1) Search for an existing keyword or number = results are ok 2) Search for a non-existing keyword or number = 'no results found' - ok 3) Now click 'used saved' - no reports are showing up (In reply to Katrin Fischer from comment #5) > I apologize to the test. It's innocent. > > But: somehow I manage to make all my reports disappear. Can someone try and > confirm? > > 1) Search for an existing keyword or number = results are ok > 2) Search for a non-existing keyword or number = 'no results found' - ok > 3) Now click 'used saved' - no reports are showing up Confirmed, but not related to this patch (come from commit 8360343fbc1fb4d8806db951aea8b04ad99d00c1 Date: Wed Apr 6 14:56:45 2011 +1200 Bug 6033 : wr77488 : report selection filter Please open a new bug report. Created attachment 38046 [details] [review] Bug 10706: Delete saved_reports to be sure no reports existed We need to be sure no report existed before launching the tests. Created attachment 38048 [details] [review] [PASSED QA] Bug 10706: Search reports by id This patch adds the ability to search reports by their id. Test plan: 1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved) 2/ Search for a report id (refer to the ID column in the table) 3/ The result should be consistent That the filters are not kept, already existed. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 38049 [details] [review] [PASSED QA] Bug 10706: Add test Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 38051 [details] [review] [PASSED QA] Bug 10706: Delete saved_reports to be sure no reports existed We need to be sure no report existed before launching the tests. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Patches pushed to master. Thanks Jonathan! |